Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
143 lines
4.2 KiB
Python
143 lines
4.2 KiB
Python
"""Tests for Discord message reactions tied to processing lifecycle hooks."""
|
|
|
|
import asyncio
|
|
import sys
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.platforms.base import MessageEvent, MessageType, ProcessingOutcome, SendResult
|
|
from gateway.session import SessionSource, build_session_key
|
|
|
|
|
|
def _ensure_discord_mock():
|
|
if "discord" in sys.modules and hasattr(sys.modules["discord"], "__file__"):
|
|
return
|
|
|
|
discord_mod = MagicMock()
|
|
discord_mod.Intents.default.return_value = MagicMock()
|
|
discord_mod.DMChannel = type("DMChannel", (), {})
|
|
discord_mod.Thread = type("Thread", (), {})
|
|
discord_mod.ForumChannel = type("ForumChannel", (), {})
|
|
discord_mod.Interaction = object
|
|
discord_mod.app_commands = SimpleNamespace(
|
|
describe=lambda **kwargs: (lambda fn: fn),
|
|
choices=lambda **kwargs: (lambda fn: fn),
|
|
Choice=lambda **kwargs: SimpleNamespace(**kwargs),
|
|
)
|
|
|
|
ext_mod = MagicMock()
|
|
commands_mod = MagicMock()
|
|
commands_mod.Bot = MagicMock
|
|
ext_mod.commands = commands_mod
|
|
|
|
sys.modules.setdefault("discord", discord_mod)
|
|
sys.modules.setdefault("discord.ext", ext_mod)
|
|
sys.modules.setdefault("discord.ext.commands", commands_mod)
|
|
|
|
|
|
_ensure_discord_mock()
|
|
|
|
from plugins.platforms.discord.adapter import DiscordAdapter # noqa: E402
|
|
|
|
|
|
class FakeTree:
|
|
def __init__(self):
|
|
self.commands = {}
|
|
|
|
def command(self, *, name, description):
|
|
def decorator(fn):
|
|
self.commands[name] = fn
|
|
return fn
|
|
|
|
return decorator
|
|
|
|
|
|
@pytest.fixture
|
|
def adapter():
|
|
config = PlatformConfig(enabled=True, token="***")
|
|
adapter = DiscordAdapter(config)
|
|
adapter._client = SimpleNamespace(
|
|
tree=FakeTree(),
|
|
get_channel=lambda _id: None,
|
|
fetch_channel=AsyncMock(),
|
|
user=SimpleNamespace(id=99999, name="HermesBot"),
|
|
)
|
|
return adapter
|
|
|
|
|
|
def _make_event(message_id: str, raw_message) -> MessageEvent:
|
|
return MessageEvent(
|
|
text="hello",
|
|
message_type=MessageType.TEXT,
|
|
source=SessionSource(
|
|
platform=Platform.DISCORD,
|
|
chat_id="123",
|
|
chat_type="dm",
|
|
user_id="42",
|
|
user_name="Jezza",
|
|
),
|
|
raw_message=raw_message,
|
|
message_id=message_id,
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_process_message_background_adds_and_swaps_reactions(adapter):
|
|
raw_message = SimpleNamespace(
|
|
add_reaction=AsyncMock(),
|
|
remove_reaction=AsyncMock(),
|
|
)
|
|
|
|
async def handler(_event):
|
|
await asyncio.sleep(0)
|
|
return "ack"
|
|
|
|
async def hold_typing(_chat_id, interval=2.0, metadata=None):
|
|
await asyncio.Event().wait()
|
|
|
|
adapter.set_message_handler(handler)
|
|
adapter.send = AsyncMock(return_value=SendResult(success=True, message_id="999"))
|
|
adapter._keep_typing = hold_typing
|
|
|
|
event = _make_event("1", raw_message)
|
|
await adapter._process_message_background(event, build_session_key(event.source))
|
|
|
|
assert raw_message.add_reaction.await_args_list[0].args == ("👀",)
|
|
assert raw_message.remove_reaction.await_args_list[0].args == ("👀", adapter._client.user)
|
|
assert raw_message.add_reaction.await_args_list[1].args == ("✅",)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reactions_disabled_via_env(adapter, monkeypatch):
|
|
"""When DISCORD_REACTIONS=false, no reactions should be added."""
|
|
monkeypatch.setenv("DISCORD_REACTIONS", "false")
|
|
|
|
raw_message = SimpleNamespace(
|
|
add_reaction=AsyncMock(),
|
|
remove_reaction=AsyncMock(),
|
|
)
|
|
|
|
async def handler(_event):
|
|
await asyncio.sleep(0)
|
|
return "ack"
|
|
|
|
async def hold_typing(_chat_id, interval=2.0, metadata=None):
|
|
await asyncio.Event().wait()
|
|
|
|
adapter.set_message_handler(handler)
|
|
adapter.send = AsyncMock(return_value=SendResult(success=True, message_id="999"))
|
|
adapter._keep_typing = hold_typing
|
|
|
|
event = _make_event("4", raw_message)
|
|
await adapter._process_message_background(event, build_session_key(event.source))
|
|
|
|
raw_message.add_reaction.assert_not_awaited()
|
|
raw_message.remove_reaction.assert_not_awaited()
|
|
# Response should still be sent
|
|
adapter.send.assert_awaited_once()
|
|
|
|
|