baau
b51c4e6a78
Salvage of #57657, ported onto the plugin layout (the adapter moved from gateway/platforms/feishu.py to plugins/platforms/feishu/adapter.py since the PR's base). lark_oapi takes seconds to import and holds the GIL doing it; the module-level import made every gateway boot pay that cost even with Feishu unconfigured. - _load_lark_oapi() with double-checked locking binds the SDK globals on first use; connect() and _standalone_send() call it via asyncio.to_thread so the loop never blocks on the import. - probe_bot() also calls _load_lark_oapi() (sync context) so the SDK probe path is preserved rather than silently degrading to the HTTP fallback before a first connect. - check_feishu_requirements() is install-only and no longer rebinds globals; test_feishu.py gets a setUpModule that binds them eagerly for tests that inject fake clients. Includes the dedicated lazy-import test file (check-does-not-import, connect-loads-on-worker-thread).
56 lines
1.9 KiB
Python
56 lines
1.9 KiB
Python
"""Regression coverage for deferred Feishu SDK loading."""
|
|
|
|
import asyncio
|
|
import os
|
|
import tempfile
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
|
|
def _feishu_adapter_module():
|
|
"""Import the adapter with the Windows app-data root available in CI."""
|
|
with patch.dict(os.environ, {"LOCALAPPDATA": tempfile.gettempdir()}):
|
|
from plugins.platforms.feishu import adapter
|
|
|
|
return adapter
|
|
|
|
|
|
def test_configured_feishu_dependency_check_does_not_load_sdk():
|
|
"""Gateway configuration can validate Feishu without importing its SDK."""
|
|
feishu_adapter = _feishu_adapter_module()
|
|
|
|
with (
|
|
patch.object(feishu_adapter, "FEISHU_AVAILABLE", False),
|
|
patch("tools.lazy_deps.ensure", autospec=True) as ensure,
|
|
):
|
|
assert feishu_adapter.check_feishu_requirements() is True
|
|
assert feishu_adapter.FEISHU_AVAILABLE is False
|
|
|
|
ensure.assert_called_once_with("platform.feishu", prompt=False)
|
|
|
|
|
|
def test_feishu_connect_loads_sdk_on_worker_thread():
|
|
"""The first SDK import is deferred until a configured adapter connects."""
|
|
from gateway.config import PlatformConfig
|
|
feishu_adapter = _feishu_adapter_module()
|
|
|
|
adapter = feishu_adapter.FeishuAdapter(
|
|
PlatformConfig(
|
|
extra={
|
|
"app_id": "cli_test",
|
|
"app_secret": "secret_test",
|
|
"connection_mode": "websocket",
|
|
}
|
|
)
|
|
)
|
|
|
|
with (
|
|
patch.object(feishu_adapter, "FEISHU_AVAILABLE", False),
|
|
patch.object(feishu_adapter, "_load_lark_oapi", return_value=True) as load_sdk,
|
|
patch.object(feishu_adapter.asyncio, "to_thread", new_callable=AsyncMock, return_value=True) as to_thread,
|
|
patch.object(adapter, "_connect_with_retry", new_callable=AsyncMock),
|
|
patch.object(feishu_adapter, "acquire_scoped_lock", return_value=(True, {})),
|
|
):
|
|
assert asyncio.run(adapter.connect()) is True
|
|
|
|
to_thread.assert_awaited_once_with(load_sdk)
|