Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
88 lines
2.8 KiB
Python
88 lines
2.8 KiB
Python
"""Tests for Slack channel_skill_bindings auto-skill resolution."""
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
def _make_adapter(extra=None):
|
|
"""Create a minimal SlackAdapter stub with the given ``config.extra``."""
|
|
from plugins.platforms.slack.adapter import SlackAdapter
|
|
adapter = object.__new__(SlackAdapter)
|
|
adapter.config = MagicMock()
|
|
adapter.config.extra = extra or {}
|
|
return adapter
|
|
|
|
|
|
def _resolve(adapter, channel_id, parent_id=None):
|
|
from gateway.platforms.base import resolve_channel_skills
|
|
return resolve_channel_skills(adapter.config.extra, channel_id, parent_id)
|
|
|
|
|
|
class TestSlackResolveChannelSkills:
|
|
|
|
def test_match_by_dm_channel_id(self):
|
|
"""The primary use case: binding a skill to a Slack DM channel."""
|
|
adapter = _make_adapter({
|
|
"channel_skill_bindings": [
|
|
{"id": "D0ATH9TQ0G6", "skills": ["german-flashcards"]},
|
|
]
|
|
})
|
|
assert _resolve(adapter, "D0ATH9TQ0G6") == ["german-flashcards"]
|
|
|
|
|
|
def test_no_match_returns_none(self):
|
|
adapter = _make_adapter({
|
|
"channel_skill_bindings": [
|
|
{"id": "D0AAA", "skills": ["skill-a"]},
|
|
]
|
|
})
|
|
assert _resolve(adapter, "D0BBB") is None
|
|
|
|
def test_single_skill_string(self):
|
|
adapter = _make_adapter({
|
|
"channel_skill_bindings": [
|
|
{"id": "D0ATH9TQ0G6", "skill": "german-flashcards"},
|
|
]
|
|
})
|
|
assert _resolve(adapter, "D0ATH9TQ0G6") == ["german-flashcards"]
|
|
|
|
|
|
def test_empty_skills_list_returns_none(self):
|
|
adapter = _make_adapter({
|
|
"channel_skill_bindings": [
|
|
{"id": "D0ABC", "skills": []},
|
|
]
|
|
})
|
|
assert _resolve(adapter, "D0ABC") is None
|
|
|
|
|
|
class TestSlackMessageEventAutoSkill:
|
|
"""Integration-style test: verify auto_skill propagates to MessageEvent."""
|
|
|
|
def test_message_event_carries_auto_skill(self):
|
|
"""Simulate the handler wiring: resolve + attach to MessageEvent."""
|
|
from gateway.platforms.base import MessageEvent, MessageType, Platform, SessionSource, resolve_channel_skills
|
|
|
|
config_extra = {
|
|
"channel_skill_bindings": [
|
|
{"id": "D0ATH9TQ0G6", "skills": ["german-flashcards"]},
|
|
]
|
|
}
|
|
auto_skill = resolve_channel_skills(config_extra, "D0ATH9TQ0G6", None)
|
|
|
|
source = SessionSource(
|
|
platform=Platform.SLACK,
|
|
chat_id="D0ATH9TQ0G6",
|
|
chat_name="Mats",
|
|
chat_type="dm",
|
|
user_id="U0ABC",
|
|
user_name="Mats",
|
|
)
|
|
event = MessageEvent(
|
|
text="work",
|
|
message_type=MessageType.TEXT,
|
|
source=source,
|
|
raw_message={},
|
|
message_id="123.456",
|
|
auto_skill=auto_skill,
|
|
)
|
|
assert event.auto_skill == ["german-flashcards"]
|