Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
96 lines
3.0 KiB
Python
96 lines
3.0 KiB
Python
"""Tests for WhatsApp owner-message metadata and source-level text tagging.
|
|
|
|
The Node bridge sets ``fromOwner: true`` on inbound `fromMe` messages that
|
|
look owner-typed (linked-device send, not echoed from /send) when the
|
|
operator opts into ``WHATSAPP_FORWARD_OWNER_MESSAGES``. These tests pin
|
|
the adapter's responsibility: lift that flag onto
|
|
``MessageEvent.metadata["whatsapp_from_owner"]``, prefix ``MessageEvent.text``
|
|
with ``[owner reply] ``, and otherwise leave metadata absent and text
|
|
unchanged. The env-var gate itself lives in the bridge — the adapter just
|
|
trusts the payload.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from plugins.platforms.whatsapp.adapter import WhatsAppAdapter
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _whatsapp_open_optin(monkeypatch):
|
|
"""Opt into WhatsApp allow-all so ``dm_policy: open`` dispatch tests run.
|
|
|
|
The adapter fails closed on ``open`` without an allow-all opt-in
|
|
(SECURITY.md 2.6); these owner-DM tests set ``_dm_policy = "open"``.
|
|
"""
|
|
monkeypatch.setenv("WHATSAPP_ALLOW_ALL_USERS", "true")
|
|
|
|
|
|
def _make_adapter():
|
|
adapter = WhatsAppAdapter.__new__(WhatsAppAdapter)
|
|
adapter.platform = Platform.WHATSAPP
|
|
adapter.config = PlatformConfig(enabled=True)
|
|
adapter._message_handler = AsyncMock()
|
|
adapter._dm_policy = "open"
|
|
adapter._allow_from = set()
|
|
adapter._group_policy = "open"
|
|
adapter._group_allow_from = set()
|
|
adapter._mention_patterns = []
|
|
adapter._free_response_chats = set()
|
|
adapter._whatsapp_free_response_chats = lambda: set()
|
|
return adapter
|
|
|
|
|
|
def _dm_payload(**overrides):
|
|
payload = {
|
|
"messageId": "M1",
|
|
"chatId": "6281234567890@s.whatsapp.net",
|
|
"senderId": "6281234567890@s.whatsapp.net",
|
|
"senderName": "Customer",
|
|
"chatName": "Customer",
|
|
"isGroup": False,
|
|
"body": "hi from the linked phone",
|
|
"hasMedia": False,
|
|
"mediaType": "",
|
|
"mediaUrls": [],
|
|
"mentionedIds": [],
|
|
"quotedParticipant": "",
|
|
"botIds": [],
|
|
"timestamp": 0,
|
|
}
|
|
payload.update(overrides)
|
|
return payload
|
|
|
|
|
|
def test_metadata_flag_set_when_payload_has_from_owner():
|
|
adapter = _make_adapter()
|
|
payload = _dm_payload(fromOwner=True)
|
|
|
|
event = asyncio.run(adapter._build_message_event(payload))
|
|
|
|
assert event is not None
|
|
assert event.metadata.get("whatsapp_from_owner") is True
|
|
assert event.text.startswith("[owner reply] ")
|
|
assert event.text == "[owner reply] hi from the linked phone"
|
|
|
|
|
|
def test_from_owner_does_not_double_prefix_when_already_tagged():
|
|
adapter = _make_adapter()
|
|
payload = _dm_payload(
|
|
fromOwner=True,
|
|
body="[owner reply] already tagged",
|
|
)
|
|
|
|
event = asyncio.run(adapter._build_message_event(payload))
|
|
|
|
assert event is not None
|
|
assert event.metadata.get("whatsapp_from_owner") is True
|
|
assert event.text == "[owner reply] already tagged"
|
|
|
|
|