Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
43 lines
1.7 KiB
Python
43 lines
1.7 KiB
Python
"""Regression: the WhatsApp inbound-media path validator follows the active
|
|
profile override.
|
|
|
|
The bridge writes inbound media into the active profile's cache (resolved via
|
|
get_image_cache_dir() etc.). _is_allowed_bridge_path() validates those paths.
|
|
It previously checked against IMAGE_CACHE_DIR / AUDIO_CACHE_DIR module
|
|
constants value-imported at import time, so under a profile override the
|
|
validator rejected media the bridge had legitimately written into the override
|
|
profile's cache. The validator must resolve the cache roots per-call.
|
|
"""
|
|
from pathlib import Path
|
|
|
|
from hermes_constants import reset_hermes_home_override, set_hermes_home_override
|
|
|
|
|
|
def _make_profile(root: Path) -> Path:
|
|
for sub in ("cache/images", "cache/audio", "cache/videos", "cache/documents"):
|
|
(root / sub).mkdir(parents=True, exist_ok=True)
|
|
return root
|
|
|
|
|
|
def test_validator_follows_override_switch(tmp_path):
|
|
"""A path under profile A is rejected while the override is profile B."""
|
|
from plugins.platforms.whatsapp.adapter import _is_allowed_bridge_path
|
|
|
|
prof_a = _make_profile(tmp_path / "profA")
|
|
prof_b = _make_profile(tmp_path / "profB")
|
|
a_media = prof_a / "cache" / "images" / "img_a.jpg"
|
|
a_media.write_bytes(b"\xff\xd8\xff\x00")
|
|
|
|
# Under B, B's own media validates...
|
|
b_media = prof_b / "cache" / "images" / "img_b.jpg"
|
|
b_media.write_bytes(b"\xff\xd8\xff\x00")
|
|
token = set_hermes_home_override(str(prof_b))
|
|
try:
|
|
assert _is_allowed_bridge_path(str(b_media)) is True
|
|
# ...and a path from a *different* profile is not in B's cache roots.
|
|
assert _is_allowed_bridge_path(str(a_media)) is False
|
|
finally:
|
|
reset_hermes_home_override(token)
|
|
|
|
|