Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
83 lines
2.5 KiB
Python
83 lines
2.5 KiB
Python
"""Tests for `_print_curator_recent_run_notice`.
|
|
|
|
The notice prints the most recent curator run summary on `hermes update`,
|
|
exactly once per run. Show-once is enforced by stamping
|
|
`last_run_summary_shown_at` in curator state after printing.
|
|
|
|
Why this matters: the curator runs in the background (gateway tick + CLI
|
|
session start) so users normally never see the rename map. `hermes update`
|
|
is the high-attention surface where consolidations should land.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib
|
|
from datetime import datetime, timedelta, timezone
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def curator_env(tmp_path, monkeypatch, capsys):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
(home / "skills").mkdir()
|
|
(home / "logs").mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
|
|
import hermes_constants
|
|
importlib.reload(hermes_constants)
|
|
from agent import curator
|
|
importlib.reload(curator)
|
|
from hermes_cli import main as hermes_main
|
|
importlib.reload(hermes_main)
|
|
|
|
yield {
|
|
"curator": curator,
|
|
"main": hermes_main,
|
|
"capsys": capsys,
|
|
}
|
|
|
|
|
|
def _set_state(curator_mod, **fields):
|
|
state = curator_mod.load_state()
|
|
state.update(fields)
|
|
curator_mod.save_state(state)
|
|
|
|
|
|
|
|
|
|
def test_silent_when_summary_is_single_line(curator_env):
|
|
"""No archives = no rename map = nothing to surface. But still stamps shown."""
|
|
now = datetime.now(timezone.utc).isoformat()
|
|
_set_state(
|
|
curator_env["curator"],
|
|
last_run_at=now,
|
|
last_run_summary="auto: no changes; llm: no change",
|
|
)
|
|
curator_env["main"]._print_curator_recent_run_notice()
|
|
out = curator_env["capsys"].readouterr().out
|
|
assert "Skill curator — last run" not in out
|
|
# Should still mark shown so we don't reconsider on every update.
|
|
state = curator_env["curator"].load_state()
|
|
assert state["last_run_summary_shown_at"] == now
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_format_time_ago_buckets(curator_env):
|
|
"""Smoke test the time formatter — drives the `last run Xh ago` line."""
|
|
fmt = curator_env["main"]._format_time_ago
|
|
now = datetime.now(timezone.utc)
|
|
assert fmt((now - timedelta(seconds=10)).isoformat()) == "just now"
|
|
assert fmt((now - timedelta(minutes=5)).isoformat()) == "5m ago"
|
|
assert fmt((now - timedelta(hours=3)).isoformat()) == "3h ago"
|
|
assert fmt((now - timedelta(days=2)).isoformat()) == "2d ago"
|
|
assert fmt("not-a-real-iso-string") == "recently"
|