Teknium
8800ec66d6
Follow-ups on top of the salvaged CommandCode provider plugin (PR #32909): - hermes_cli/config_defaults.py: COMMANDCODE_API_KEY setup-wizard entry - hermes_cli/doctor.py: add key to the doctor env-var scan list (health check comes free via the pluggable-profile loop) - hermes_cli/dump.py: include commandcode in debug-dump api_keys - docs: provider table row, fallback-provider table + supported lists - tests: doctor dedicated-skip test now uses exact-name checks so Bearer-authed Anthropic-COMPATIBLE gateways (CommandCode (Anthropic)) are allowed in the generic loop while native anthropic stays skipped E2E verified with real imports: profile registration, aliases, PROVIDER_REGISTRY auto-extension, bearer-auth host match (positive + negative), live /models fetch (55 models).
45 lines
1.8 KiB
Python
45 lines
1.8 KiB
Python
"""Regression: hermes doctor must not run a generic Bearer-auth health
|
|
check for providers that already have a dedicated check (Anthropic,
|
|
OpenRouter, Bedrock).
|
|
|
|
Anthropic's native API requires `x-api-key` + `anthropic-version` headers;
|
|
the generic loop sends `Authorization: Bearer ...` which Anthropic answers
|
|
with HTTP 404. The dedicated check at hermes_cli/doctor.py already covers
|
|
Anthropic with the right headers, so the pluggable profile must be
|
|
skipped by `_build_apikey_providers_list()`.
|
|
|
|
See: NousResearch/hermes-agent#22346
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
def test_build_apikey_providers_list_skips_dedicated_check_providers():
|
|
from hermes_cli import doctor
|
|
|
|
# Force a rebuild — the module caches the list on first call.
|
|
doctor._APIKEY_PROVIDERS_CACHE = None
|
|
entries = doctor._build_apikey_providers_list()
|
|
|
|
# Tuple shape: (display_name, env_vars, default_url, base_env, supports_health_check)
|
|
names = {entry[0].lower() for entry in entries}
|
|
# Exact-name checks, not substring: third-party gateways that expose an
|
|
# Anthropic-compatible endpoint under Bearer auth (e.g. "CommandCode
|
|
# (Anthropic)") legitimately belong in the generic loop. Only the native
|
|
# Anthropic profile (x-api-key headers) must be skipped.
|
|
assert "anthropic" not in names, (
|
|
f"Anthropic provider profile leaked into generic Bearer-auth health "
|
|
f"check loop. Dedicated check above already covers it with "
|
|
f"x-api-key headers. Got entries: {sorted(names)}"
|
|
)
|
|
assert "openrouter" not in names, (
|
|
f"OpenRouter has a dedicated check; generic loop must skip it. "
|
|
f"Got: {sorted(names)}"
|
|
)
|
|
assert not any("bedrock" in name for name in names), (
|
|
f"Bedrock uses AWS SDK creds, not Bearer auth; generic loop must skip. "
|
|
f"Got: {sorted(names)}"
|
|
)
|
|
|
|
|