Teknium
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
109 lines
3.7 KiB
Python
109 lines
3.7 KiB
Python
"""Presence-watchdog tests.
|
|
|
|
spectrum-ts only reconnects when its inbound iterator throws or ends; a
|
|
half-open ("zombie") gRPC socket makes the iterator hang forever (no error, no
|
|
end), so inbound silently dies until the sidecar is restarted. The adapter's
|
|
presence watchdog probes the upstream channel via the sidecar's ``/probe``
|
|
endpoint and respawns the sidecar after repeated probe failures.
|
|
|
|
These tests exercise the watchdog's decision logic (probe -> count failures ->
|
|
respawn; success resets; recent inbound traffic skips the probe) without
|
|
spawning Node, binding ports, or hitting the network.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import time
|
|
from typing import Any, List
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
from plugins.platforms.photon.adapter import PhotonAdapter
|
|
|
|
|
|
def _make_adapter(monkeypatch: pytest.MonkeyPatch, **extra: Any) -> PhotonAdapter:
|
|
monkeypatch.setenv("PHOTON_PROJECT_ID", "test-project-id")
|
|
monkeypatch.setenv("PHOTON_PROJECT_SECRET", "test-project-secret")
|
|
cfg = PlatformConfig(enabled=True, token="", extra=dict(extra))
|
|
return PhotonAdapter(cfg)
|
|
|
|
|
|
def test_probe_config_defaults(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
a = _make_adapter(monkeypatch)
|
|
# Conservative by default: probe only after 10+ minutes of stream silence
|
|
# so quiet shared lines never trigger restart storms.
|
|
assert a._probe_interval == 600.0
|
|
assert a._probe_timeout == 10.0
|
|
assert a._probe_max_failures == 3
|
|
assert a._probe_enabled is True
|
|
|
|
|
|
def test_note_activity_resets_failures(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
a = _make_adapter(monkeypatch)
|
|
a._probe_failures = 2
|
|
before = a._last_upstream_activity
|
|
time.sleep(0.001)
|
|
a._note_upstream_activity()
|
|
assert a._probe_failures == 0
|
|
assert a._last_upstream_activity > before
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_respawn_after_max_failures(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
"""The core fix: N consecutive dead probes -> exactly one respawn."""
|
|
a = _make_adapter(monkeypatch, probe_max_failures=3)
|
|
|
|
respawns: List[str] = []
|
|
|
|
async def _fake_respawn(reason: str) -> None:
|
|
respawns.append(reason)
|
|
a._note_upstream_activity() # mirror real respawn (clears failures)
|
|
|
|
async def _hung_probe() -> str:
|
|
return "hung"
|
|
|
|
monkeypatch.setattr(a, "_respawn_sidecar", _fake_respawn)
|
|
monkeypatch.setattr(a, "_probe_once", _hung_probe)
|
|
|
|
# Simulate the watchdog's per-iteration decision logic directly (no sleeps).
|
|
a._last_upstream_activity = time.monotonic() - 999 # force a probe each time
|
|
for _ in range(3):
|
|
verdict = await a._probe_once()
|
|
assert verdict == "hung"
|
|
a._probe_failures += 1
|
|
if a._probe_failures >= a._probe_max_failures:
|
|
await a._respawn_sidecar("test")
|
|
|
|
assert respawns == ["test"]
|
|
assert a._probe_failures == 0 # reset by the (faked) respawn
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_success_resets_failure_count(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
"""A live probe between dead ones prevents a respawn (failures reset)."""
|
|
a = _make_adapter(monkeypatch, probe_max_failures=3)
|
|
|
|
respawns: List[str] = []
|
|
|
|
async def _fake_respawn(reason: str) -> None:
|
|
respawns.append(reason)
|
|
|
|
monkeypatch.setattr(a, "_respawn_sidecar", _fake_respawn)
|
|
|
|
# Two failures, then a success, then two more failures: never hits 3 in a row.
|
|
sequence = [False, False, True, False, False]
|
|
for alive in sequence:
|
|
if alive:
|
|
a._note_upstream_activity()
|
|
else:
|
|
a._probe_failures += 1
|
|
if a._probe_failures >= a._probe_max_failures:
|
|
await a._respawn_sidecar("should-not-fire")
|
|
|
|
assert respawns == []
|
|
assert a._probe_failures == 2
|
|
|
|
|