Teknium
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
60 lines
2.0 KiB
Python
60 lines
2.0 KiB
Python
"""Regression tests for #47828: switch_model must not pair a new provider
|
|
label with the previous provider's base_url when the resolver returns no
|
|
new base_url for a genuine provider change.
|
|
"""
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from run_agent import AIAgent
|
|
from agent.context_compressor import ContextCompressor
|
|
|
|
|
|
def _make_agent_with_compressor(provider="copilot", base_url="https://api.githubcopilot.com") -> AIAgent:
|
|
"""Build a minimal AIAgent with a context_compressor, skipping __init__."""
|
|
agent = AIAgent.__new__(AIAgent)
|
|
|
|
agent.model = "claude-opus-4.8"
|
|
agent.provider = provider
|
|
agent.base_url = base_url
|
|
agent.api_key = "sk-primary"
|
|
agent.api_mode = "chat_completions"
|
|
agent.client = MagicMock()
|
|
agent.quiet_mode = True
|
|
agent._config_context_length = None
|
|
|
|
compressor = ContextCompressor(
|
|
model=agent.model,
|
|
threshold_percent=0.50,
|
|
base_url=base_url,
|
|
api_key="sk-primary",
|
|
provider=provider,
|
|
quiet_mode=True,
|
|
config_context_length=None,
|
|
)
|
|
agent.context_compressor = compressor
|
|
agent._primary_runtime = {}
|
|
|
|
return agent
|
|
|
|
|
|
@patch("agent.model_metadata.get_model_context_length", return_value=131_072)
|
|
def test_switch_model_rejects_stale_base_url_on_provider_change(mock_ctx_len):
|
|
"""A provider change with no resolved base_url must fail loud instead of
|
|
silently keeping the previous provider's endpoint (#47828)."""
|
|
agent = _make_agent_with_compressor(provider="copilot", base_url="https://api.githubcopilot.com")
|
|
|
|
with pytest.raises(ValueError, match="no base_url resolved"):
|
|
agent.switch_model("MiniMax-M3", "custom:minimax", api_key="sk-minimax", base_url="")
|
|
|
|
# Rollback must leave the agent fully on the old (provider, base_url) pair —
|
|
# not a mismatched new-model/old-endpoint hybrid.
|
|
assert agent.provider == "copilot"
|
|
assert agent.base_url == "https://api.githubcopilot.com"
|
|
assert agent.model == "claude-opus-4.8"
|
|
|
|
|
|
|
|
|