Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
82 lines
2.7 KiB
Python
82 lines
2.7 KiB
Python
"""Tests for optional-skills/productivity/memento-flashcards/scripts/youtube_quiz.py"""
|
|
|
|
import json
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest import mock
|
|
|
|
import pytest
|
|
|
|
SCRIPTS_DIR = Path(__file__).resolve().parents[2] / "optional-skills" / "productivity" / "memento-flashcards" / "scripts"
|
|
sys.path.insert(0, str(SCRIPTS_DIR))
|
|
|
|
import youtube_quiz
|
|
|
|
|
|
def _run(capsys, argv: list[str]) -> dict:
|
|
"""Run main() with given argv and return parsed JSON output."""
|
|
with mock.patch("sys.argv", ["youtube_quiz"] + argv):
|
|
youtube_quiz.main()
|
|
captured = capsys.readouterr()
|
|
return json.loads(captured.out)
|
|
|
|
|
|
class TestNormalizeSegments:
|
|
def test_basic(self):
|
|
segments = [{"text": "hello "}, {"text": " world"}]
|
|
assert youtube_quiz._normalize_segments(segments) == "hello world"
|
|
|
|
|
|
def test_whitespace_only(self):
|
|
assert youtube_quiz._normalize_segments([{"text": " "}, {"text": " "}]) == ""
|
|
|
|
def test_collapses_multiple_spaces(self):
|
|
segments = [{"text": "a b"}, {"text": "c d"}]
|
|
assert youtube_quiz._normalize_segments(segments) == "a b c d"
|
|
|
|
|
|
|
|
|
|
class TestFetchWithMockedAPI:
|
|
def _make_mock_module(self, segments=None, raise_exc=None):
|
|
"""Create a mock youtube_transcript_api module."""
|
|
mock_module = mock.MagicMock()
|
|
|
|
mock_api_instance = mock.MagicMock()
|
|
mock_module.YouTubeTranscriptApi.return_value = mock_api_instance
|
|
|
|
if raise_exc:
|
|
mock_api_instance.fetch.side_effect = raise_exc
|
|
else:
|
|
raw_data = segments or [{"text": "Hello world"}]
|
|
result = mock.MagicMock()
|
|
result.to_raw_data.return_value = raw_data
|
|
mock_api_instance.fetch.return_value = result
|
|
|
|
return mock_module
|
|
|
|
def test_successful_fetch(self, capsys):
|
|
mock_mod = self._make_mock_module(
|
|
segments=[{"text": "This is a test"}, {"text": "transcript segment"}]
|
|
)
|
|
with mock.patch.dict("sys.modules", {"youtube_transcript_api": mock_mod}):
|
|
result = _run(capsys, ["fetch", "abc123"])
|
|
|
|
assert result["ok"] is True
|
|
assert result["video_id"] == "abc123"
|
|
assert "This is a test" in result["transcript"]
|
|
assert "transcript segment" in result["transcript"]
|
|
|
|
def test_fetch_error(self, capsys):
|
|
mock_mod = self._make_mock_module(raise_exc=Exception("Video unavailable"))
|
|
with mock.patch.dict("sys.modules", {"youtube_transcript_api": mock_mod}):
|
|
with pytest.raises(SystemExit):
|
|
_run(capsys, ["fetch", "bad_id"])
|
|
|
|
captured = capsys.readouterr()
|
|
result = json.loads(captured.out)
|
|
assert result["ok"] is False
|
|
assert result["error"] == "transcript_unavailable"
|
|
|
|
|