Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
34 lines
1.2 KiB
Python
34 lines
1.2 KiB
Python
"""Tests for the MCPServerTask reconnect signal.
|
|
|
|
When the OAuth layer cannot recover in-place (e.g., external refresh of a
|
|
single-use refresh_token made the SDK's in-memory refresh fail), the tool
|
|
handler signals MCPServerTask to tear down the current MCP session and
|
|
reconnect with fresh credentials. This file exercises the signal plumbing
|
|
in isolation from the full stdio/http transport machinery.
|
|
"""
|
|
import asyncio
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reconnect_event_attribute_exists():
|
|
"""MCPServerTask has a _reconnect_event alongside _shutdown_event."""
|
|
from tools.mcp_tool import MCPServerTask
|
|
task = MCPServerTask("test")
|
|
assert hasattr(task, "_reconnect_event")
|
|
assert isinstance(task._reconnect_event, asyncio.Event)
|
|
assert not task._reconnect_event.is_set()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_wait_for_lifecycle_event_shutdown_wins_when_both_set():
|
|
"""If both events are set simultaneously, shutdown takes precedence."""
|
|
from tools.mcp_tool import MCPServerTask
|
|
task = MCPServerTask("test")
|
|
|
|
task._shutdown_event.set()
|
|
task._reconnect_event.set()
|
|
reason = await task._wait_for_lifecycle_event()
|
|
assert reason == "shutdown"
|