Teknium
80631c4aea
Truncated terminal output was information LOSS: the middle was gone
and the only recovery was re-running the command (data: 1,394
truncation markers in a 250k-call window, with re-runs and grep
retries chained behind the big ones).
Truncation is now deferred retrieval (opencode/goose/qwen-code
pattern, codex's original_token_count idea):
- tools/environments/base.py: _BoundedOutputCollector gains an
optional spill tee — when foreground output overflows the capture
window, the FULL stream is teed to
~/.hermes/cache/terminal-output/out-*.log (lazy file creation with
backlog backfill, 5MB hard cap, 7-day opportunistic cleanup,
disk errors never break execution). All three _wait_for_process
returns attach {output_total_chars, full_output_path} via a shared
finalizer.
- tools/terminal_tool.py: redacts the spill with the same
redact_terminal_output pass as the visible output (no secret
persists unmasked), then surfaces output_total_chars,
full_output_path, and a truncation_note pointing at
search_files/read_file instead of a re-run.
Non-truncated results are byte-identical; internal unbounded
consumers (file-ops cat reads, RPC reads) are untouched (spill only
arms with bounded_capture=true).
68 lines
2.6 KiB
Python
68 lines
2.6 KiB
Python
"""Tests for terminal truncation spill + metadata (deferred retrieval)."""
|
|
|
|
import json
|
|
import os
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from tools.terminal_tool import terminal_tool
|
|
|
|
|
|
@pytest.fixture
|
|
def small_cap(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / ".hermes"))
|
|
import tools.tool_output_limits as lim
|
|
monkeypatch.setattr(lim, "_cached_limits", {
|
|
"max_bytes": 2000, "max_lines": 2000, "max_line_length": 2000,
|
|
})
|
|
return tmp_path
|
|
|
|
|
|
class TestTruncationSpill:
|
|
def test_truncated_output_has_metadata_and_spill(self, small_cap):
|
|
r = json.loads(terminal_tool(
|
|
"python3 -c \"print('marker_head'); [print(f'row_{i}', 'x'*80) for i in range(200)]; print('marker_tail')\"",
|
|
task_id="t-spill-1"))
|
|
assert r["exit_code"] == 0
|
|
assert "OUTPUT TRUNCATED" in r["output"]
|
|
assert r["output_total_chars"] > 2000
|
|
p = Path(r["full_output_path"])
|
|
assert p.exists()
|
|
full = p.read_text()
|
|
assert "marker_head" in full and "marker_tail" in full
|
|
# The spill contains rows that were cut from the visible window.
|
|
assert "row_100 " in full
|
|
assert "read_file" in r["truncation_note"]
|
|
|
|
def test_small_output_has_no_metadata(self, small_cap):
|
|
r = json.loads(terminal_tool("echo tiny", task_id="t-spill-2"))
|
|
assert r["exit_code"] == 0
|
|
assert "full_output_path" not in r
|
|
assert "output_total_chars" not in r
|
|
|
|
def test_spill_is_redacted(self, small_cap):
|
|
r = json.loads(terminal_tool(
|
|
"python3 -c \"print('sk-proj-' + 'a1B2c3D4e5F6g7H8i9J0' * 3); [print('pad', 'y'*90) for i in range(200)]\"",
|
|
task_id="t-spill-3"))
|
|
p = Path(r["full_output_path"])
|
|
full = p.read_text()
|
|
assert "a1B2c3D4e5F6g7H8i9J0a1B2c3D4e5F6g7H8i9J0" not in full
|
|
|
|
def test_old_spills_cleaned(self, small_cap, tmp_path):
|
|
spill_dir = tmp_path / ".hermes" / "cache" / "terminal-output"
|
|
spill_dir.mkdir(parents=True, exist_ok=True)
|
|
stale = spill_dir / "out-1-2-dead.log"
|
|
stale.write_text("old")
|
|
os.utime(stale, (1, 1))
|
|
json.loads(terminal_tool(
|
|
"python3 -c \"[print('z'*90) for i in range(200)]\"", task_id="t-spill-4"))
|
|
assert not stale.exists()
|
|
|
|
def test_failed_command_still_gets_spill(self, small_cap):
|
|
r = json.loads(terminal_tool(
|
|
"python3 -c \"[print('e'*90) for i in range(200)]; import sys; sys.exit(3)\"",
|
|
task_id="t-spill-5"))
|
|
assert r["exit_code"] == 3
|
|
assert Path(r["full_output_path"]).exists()
|