Brooklyn Nicholson
d0e41cda69
config.set matches an explicit key list and answers 4002 for anything else, so a renderer mirroring an unlisted key wrote nothing at all. The reactions toggle shipped that way: every write was rejected into a swallowed .catch(), and react_to_message stayed dark no matter what the user picked. Adds the display booleans as a recognized group so the toggle reaches the config of whichever gateway the app is actually talking to, which is the only place a check_fn can read it.
57 lines
2.1 KiB
Python
57 lines
2.1 KiB
Python
"""`config.set` has to accept the Appearance switches the desktop mirrors.
|
|
|
|
The handler matches an explicit key list and answers 4002 for everything else,
|
|
so a renderer mirroring an unlisted key writes nothing at all — and the
|
|
renderer's `.catch()` swallows the refusal, which is how message reactions
|
|
shipped with a toggle that never reached the backend gating the tool.
|
|
"""
|
|
|
|
import pytest
|
|
import yaml
|
|
|
|
from tui_gateway import server
|
|
|
|
|
|
@pytest.fixture
|
|
def config_home(tmp_path, monkeypatch):
|
|
"""Point the server's config read/write at a temp file."""
|
|
monkeypatch.setattr(server, "_hermes_home", tmp_path)
|
|
server._cfg_cache = server._cfg_mtime = server._cfg_path = None
|
|
yield tmp_path / "config.yaml"
|
|
server._cfg_cache = server._cfg_mtime = server._cfg_path = None
|
|
|
|
|
|
def _set(key, value):
|
|
return server._methods["config.set"](1, {"key": key, "value": value})
|
|
|
|
|
|
@pytest.mark.parametrize("key", sorted(server._DISPLAY_TOGGLE_KEYS))
|
|
def test_a_mirrored_switch_reaches_the_config_file(config_home, key):
|
|
"""Both directions land on disk, where the tools' check_fn reads them."""
|
|
assert _set(key, "false")["result"] == {"key": key, "value": False}
|
|
|
|
section, name = key.split(".")
|
|
assert yaml.safe_load(config_home.read_text())[section][name] is False
|
|
|
|
assert _set(key, "true")["result"] == {"key": key, "value": True}
|
|
assert yaml.safe_load(config_home.read_text())[section][name] is True
|
|
|
|
|
|
def test_a_non_boolean_is_refused_rather_than_written(config_home):
|
|
answer = _set("display.in_app_tips", "sometimes")
|
|
|
|
assert answer["error"]["code"] == 4002
|
|
assert not config_home.exists()
|
|
|
|
|
|
def test_every_key_the_renderer_mirrors_is_listed():
|
|
"""The list is the contract: a switch missing from it silently does nothing.
|
|
|
|
Kept as a relationship rather than a snapshot — it asserts that the tools
|
|
which gate on `display.<x>` all have `<x>` reachable through config.set,
|
|
not that the set has some particular size.
|
|
"""
|
|
gated = {"display.message_reactions", "display.in_app_tips", "display.in_app_tours"}
|
|
|
|
assert gated <= server._DISPLAY_TOGGLE_KEYS
|