teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
78 lines
2.7 KiB
Python
78 lines
2.7 KiB
Python
"""Status-bar goal segment (⊙ goal N/M) — active-goal-only rendering.
|
|
|
|
The segment mirrors the desktop composer goal indicator: it appears only
|
|
while a /goal is ACTIVE, shows turns used vs the turn budget, and stays out
|
|
of the bar entirely for paused/done/absent goals (those already print their
|
|
own glyph lines in the conversation thread).
|
|
"""
|
|
|
|
from datetime import datetime, timedelta
|
|
from types import SimpleNamespace
|
|
|
|
from cli import HermesCLI
|
|
|
|
|
|
def _make_cli(model: str = "anthropic/claude-sonnet-4-20250514"):
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj.model = model
|
|
cli_obj.session_start = datetime.now() - timedelta(minutes=14, seconds=32)
|
|
cli_obj.conversation_history = [{"role": "user", "content": "hi"}]
|
|
cli_obj.agent = None
|
|
return cli_obj
|
|
|
|
|
|
def _attach_goal(cli_obj, *, active: bool, turns_used: int = 3, max_turns: int = 20):
|
|
"""Bind a fake GoalManager the way _get_goal_manager caches one."""
|
|
cli_obj.session_id = "sess-goal-test"
|
|
cli_obj._goal_manager = SimpleNamespace(
|
|
session_id="sess-goal-test",
|
|
is_active=lambda: active,
|
|
state=SimpleNamespace(turns_used=turns_used, max_turns=max_turns),
|
|
)
|
|
return cli_obj
|
|
|
|
|
|
class TestStatusBarGoalSegment:
|
|
def test_goal_segment_composition(self):
|
|
cli_obj = _attach_goal(_make_cli(), active=True, turns_used=3, max_turns=20)
|
|
|
|
snapshot = cli_obj._get_status_bar_snapshot()
|
|
|
|
assert snapshot["goal_active"] is True
|
|
assert snapshot["goal_turns_used"] == 3
|
|
assert snapshot["goal_max_turns"] == 20
|
|
assert cli_obj._status_bar_goal_segment(snapshot) == "⊙ goal 3/20"
|
|
|
|
|
|
def test_goal_segment_absent_when_paused(self):
|
|
# Paused goals must NOT occupy the status bar (active-only contract).
|
|
cli_obj = _attach_goal(_make_cli(), active=False)
|
|
|
|
snapshot = cli_obj._get_status_bar_snapshot()
|
|
|
|
assert snapshot["goal_active"] is False
|
|
assert cli_obj._status_bar_goal_segment(snapshot) == ""
|
|
|
|
|
|
def test_active_goal_rendered_in_wide_status_bar(self):
|
|
cli_obj = _attach_goal(_make_cli(), active=True, turns_used=5, max_turns=20)
|
|
|
|
text = cli_obj._build_status_bar_text(width=120)
|
|
|
|
assert "⊙ goal 5/20" in text
|
|
|
|
def test_active_goal_rendered_in_medium_status_bar(self):
|
|
cli_obj = _attach_goal(_make_cli(), active=True, turns_used=1, max_turns=20)
|
|
|
|
text = cli_obj._build_status_bar_text(width=60)
|
|
|
|
assert "⊙ goal 1/20" in text
|
|
|
|
def test_active_goal_rendered_in_narrow_status_bar(self):
|
|
cli_obj = _attach_goal(_make_cli(), active=True, turns_used=2, max_turns=20)
|
|
|
|
text = cli_obj._build_status_bar_text(width=50)
|
|
|
|
assert "⊙ goal" in text
|
|
|