Teknium
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
99 lines
3.3 KiB
Python
99 lines
3.3 KiB
Python
"""Regression test for issue #65429.
|
|
|
|
An agent built with ``skip_memory=True`` AND ``enabled_toolsets=["memory"]``
|
|
used to get a memory tool wired to ``store=None`` (the built-in
|
|
``MemoryStore`` was skipped along with the external provider), so every
|
|
memory call failed silently and the main auto-capture path was dead.
|
|
|
|
The fix creates the built-in store whenever memory is enabled in config OR the
|
|
memory toolset is explicitly enabled, while the external-provider block stays
|
|
gated on ``skip_memory``.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
class _FakeOpenAI:
|
|
def __init__(self, **kw):
|
|
self.api_key = kw.get("api_key", "test")
|
|
self.base_url = kw.get("base_url", "http://test")
|
|
|
|
def close(self):
|
|
pass
|
|
|
|
|
|
def _make_agent(monkeypatch, enabled_toolsets=None, skip_memory=True):
|
|
monkeypatch.setattr("run_agent.get_tool_definitions", lambda **kw: [])
|
|
monkeypatch.setattr("run_agent.check_toolset_requirements", lambda: {})
|
|
monkeypatch.setattr("run_agent.OpenAI", _FakeOpenAI)
|
|
return AIAgent(
|
|
api_key="test-key",
|
|
base_url="http://test",
|
|
provider="openrouter",
|
|
api_mode="chat_completions",
|
|
max_iterations=1,
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=skip_memory,
|
|
enabled_toolsets=enabled_toolsets,
|
|
)
|
|
|
|
|
|
def test_skip_memory_with_memory_toolset_creates_store(monkeypatch, tmp_path):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hm"))
|
|
agent = _make_agent(monkeypatch, enabled_toolsets=["memory"], skip_memory=True)
|
|
assert agent._memory_store is not None, (
|
|
"memory toolset enabled despite skip_memory=True must still build "
|
|
"the built-in store (#65429)"
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_skip_memory_memory_tool_handler_works_and_provider_skipped(
|
|
monkeypatch, tmp_path
|
|
):
|
|
"""End-to-end behavioral check for #65429.
|
|
|
|
The memory tool handler must actually WORK (not return the
|
|
"Memory is not available" store=None error) on a skip_memory=True agent
|
|
with the memory toolset enabled, while the external memory provider
|
|
sync/prefetch stays skipped (no MemoryManager is created).
|
|
"""
|
|
import json
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / "hm"))
|
|
agent = _make_agent(monkeypatch, enabled_toolsets=["memory"], skip_memory=True)
|
|
|
|
# Provider sync/prefetch must remain skipped: skip_memory still gates the
|
|
# external memory provider block.
|
|
assert agent._memory_manager is None, (
|
|
"skip_memory=True must still skip the external memory provider"
|
|
)
|
|
|
|
# Dispatch through the same entry point the tool executor uses
|
|
# (agent/tool_executor.py wires store=agent._memory_store).
|
|
from tools.memory_tool import memory_tool
|
|
|
|
raw = memory_tool(
|
|
action="add",
|
|
target="memory",
|
|
content="User prefers concise answers.",
|
|
store=agent._memory_store,
|
|
)
|
|
result = json.loads(raw)
|
|
assert result.get("success") is True, (
|
|
f"memory tool handler must work with skip_memory=True + memory "
|
|
f"toolset (#65429), got: {raw}"
|
|
)
|
|
assert "Memory is not available" not in raw
|
|
|
|
# The write must actually persist to the profile-scoped memories dir.
|
|
memory_md = tmp_path / "hm" / "memories" / "MEMORY.md"
|
|
assert memory_md.exists()
|
|
assert "User prefers concise answers." in memory_md.read_text()
|