Teknium
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
66 lines
1.9 KiB
Python
66 lines
1.9 KiB
Python
"""Invariant tests for the declarative busy_policy on CommandDef.
|
|
|
|
Guards the contract introduced by the Guard-2 refactor (gateway/run.py):
|
|
every command's mid-run behavior is declared on its CommandDef via
|
|
``busy_policy`` / ``busy_handler`` and the historical
|
|
``ACTIVE_SESSION_BYPASS_COMMANDS`` frozenset is DERIVED from the registry
|
|
rather than hand-maintained.
|
|
"""
|
|
|
|
from hermes_cli.commands import (
|
|
ACTIVE_SESSION_BYPASS_COMMANDS,
|
|
COMMAND_REGISTRY,
|
|
VALID_BUSY_POLICIES,
|
|
is_interrupt_then_dispatch,
|
|
should_bypass_active_session,
|
|
)
|
|
|
|
# The hand-written frozenset as it existed before the busy_policy refactor.
|
|
# This is a behavior contract, not a snapshot: the derived set must remain a
|
|
# SUPERSET of these names (each had an explicit mid-run handler in the old
|
|
# Guard-2 if-chain and must keep bypassing the busy-reject catch-all).
|
|
_HISTORICAL_BYPASS_NAMES = frozenset(
|
|
{
|
|
"agents",
|
|
"approve",
|
|
"background",
|
|
"commands",
|
|
"deny",
|
|
"help",
|
|
"new",
|
|
"profile",
|
|
"queue",
|
|
"restart",
|
|
"status",
|
|
"steer",
|
|
"stop",
|
|
"update",
|
|
"version",
|
|
}
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_bypass_set_is_derived_from_registry():
|
|
expected = frozenset(
|
|
cmd.name for cmd in COMMAND_REGISTRY if cmd.busy_policy != "reject"
|
|
)
|
|
assert ACTIVE_SESSION_BYPASS_COMMANDS == expected
|
|
|
|
|
|
def test_interrupt_then_dispatch_class():
|
|
# The cancel-handoff class (Guard 1, gateway/platforms/base.py) must
|
|
# contain exactly the /stop and /new (alias /reset) commands today.
|
|
assert is_interrupt_then_dispatch("stop")
|
|
assert is_interrupt_then_dispatch("new")
|
|
assert is_interrupt_then_dispatch("reset") # alias of /new
|
|
assert not is_interrupt_then_dispatch("model")
|
|
assert not is_interrupt_then_dispatch("status")
|
|
assert not is_interrupt_then_dispatch(None)
|
|
assert not is_interrupt_then_dispatch("not-a-command")
|
|
|
|
|