6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
41 lines
1.6 KiB
Python
41 lines
1.6 KiB
Python
"""Regression: hermes doctor must not run a generic Bearer-auth health
|
|
check for providers that already have a dedicated check (Anthropic,
|
|
OpenRouter, Bedrock).
|
|
|
|
Anthropic's native API requires `x-api-key` + `anthropic-version` headers;
|
|
the generic loop sends `Authorization: Bearer ...` which Anthropic answers
|
|
with HTTP 404. The dedicated check at hermes_cli/doctor.py already covers
|
|
Anthropic with the right headers, so the pluggable profile must be
|
|
skipped by `_build_apikey_providers_list()`.
|
|
|
|
See: NousResearch/hermes-agent#22346
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
def test_build_apikey_providers_list_skips_dedicated_check_providers():
|
|
from hermes_cli import doctor
|
|
|
|
# Force a rebuild — the module caches the list on first call.
|
|
doctor._APIKEY_PROVIDERS_CACHE = None
|
|
entries = doctor._build_apikey_providers_list()
|
|
|
|
# Tuple shape: (display_name, env_vars, default_url, base_env, supports_health_check)
|
|
names = {entry[0].lower() for entry in entries}
|
|
assert not any("anthropic" in name for name in names), (
|
|
f"Anthropic provider profile leaked into generic Bearer-auth health "
|
|
f"check loop. Dedicated check above already covers it with "
|
|
f"x-api-key headers. Got entries: {sorted(names)}"
|
|
)
|
|
assert not any("openrouter" in name for name in names), (
|
|
f"OpenRouter has a dedicated check; generic loop must skip it. "
|
|
f"Got: {sorted(names)}"
|
|
)
|
|
assert not any("bedrock" in name for name in names), (
|
|
f"Bedrock uses AWS SDK creds, not Bearer auth; generic loop must skip. "
|
|
f"Got: {sorted(names)}"
|
|
)
|
|
|
|
|