Teknium
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
49 lines
1.6 KiB
Python
49 lines
1.6 KiB
Python
"""Regression test for #44037 — holographic provider leaked its SQLite
|
|
connection to GC on shutdown instead of closing it.
|
|
|
|
The corruption-mechanism framing in #44037 (TLS bytes written into the DB via
|
|
an fd-recycle race) was not reproducible from the code: dropping a sqlite
|
|
connection flushes valid pages through SQLite's own VFS, never TLS framing, and
|
|
the provider is at most a *releaser* of DB fds, not the TLS-flushing owner.
|
|
|
|
But the underlying resource-hygiene bug is real and is what this test pins:
|
|
``HolographicMemoryProvider.shutdown()`` must call ``MemoryStore.close()`` so
|
|
the ``check_same_thread=False`` connection's fd is released deterministically
|
|
on shutdown, rather than at a non-deterministic GC time on an arbitrary thread.
|
|
"""
|
|
|
|
import sqlite3
|
|
|
|
import pytest
|
|
|
|
from plugins.memory.holographic import HolographicMemoryProvider
|
|
|
|
|
|
def _make_provider(tmp_path):
|
|
db_path = str(tmp_path / "memory_store.db")
|
|
provider = HolographicMemoryProvider(config={"db_path": db_path, "hrr_dim": 64})
|
|
provider.initialize(session_id="test-session")
|
|
return provider
|
|
|
|
|
|
def test_shutdown_closes_store_connection(tmp_path):
|
|
provider = _make_provider(tmp_path)
|
|
store = provider._store
|
|
assert store is not None
|
|
conn = store._conn
|
|
|
|
# Connection is live before shutdown.
|
|
conn.execute("SELECT 1").fetchone()
|
|
|
|
provider.shutdown()
|
|
|
|
# References are dropped...
|
|
assert provider._store is None
|
|
assert provider._retriever is None
|
|
|
|
# ...AND the underlying connection was actually closed (not left to GC).
|
|
with pytest.raises(sqlite3.ProgrammingError):
|
|
conn.execute("SELECT 1")
|
|
|
|
|