liuhao1024
3d167a8271
fix(doctor): name structural state.db corruption honestly and route it to sessions recover
...
`hermes doctor` reported every write-health-probe failure as "state.db FTS write
corruption" and `--fix` ran the FTS repair ladder — rebuild, REINDEX, sqlite_master
surgery + VACUUM — on the damaged file. When the damage is structural (canonical
tables/indexes), none of those rungs can fix it, each one writes to the torn file in
place, and the operator is then told to "restore from the backup copy beside
state.db": a `.malformed-backup` that is a snapshot of the same corrupt image.
`hermes sessions recover`, the tool that actually rebuilds canonical rows into a
fresh file, was never mentioned (#88587 ; the 1.7 GB field incident lost days to it).
Discriminate before mutating. hermes_state_repair.integrity_damage_is_structural
maps `PRAGMA integrity_check` output onto the file: a `Tree N` id resolved through
sqlite_master.rootpage, an index named in `row N missing from index X`, or a
`Freelist:` line is structural unless the object is a Hermes-owned messages_fts*
table/shadow (full-matched, so a user lookalike such as archive_fts_data is never
swept into the rebuildable set). state_db_has_structural_damage runs it read-only on
a fresh connection; an integrity_check that RAISES under the walk (torn root page)
is structural too — no FTS-only fixture does that while sessions/messages read
cleanly. doctor's state check consults it first: structural damage becomes a
manual issue naming `hermes [-p <profile>] sessions recover --source <this db>
--inspect-only` (profile pinned, #105887 ) and explicitly warning off the
.malformed-backup; nothing is mutated and no backup is written. FTS-only damage
keeps the existing in-place repair path.
Verified against real fixtures: a torn `sessions` root page (before: "FTS write
corruption", --fix wrote a 1:1 malformed-backup and failed; after: structural,
recover guidance, no writes) and the 16-byte DEADBEEF messages_fts_data stomp
(still repaired in place via rebuild_fts).
Salvaged from PR #88604 (liuhao1024) onto the split doctor_state.py; the
classifier lives beside the repair ladder in hermes_state_repair so the ladder
itself can consult it next.
Fixes #88587
2026-09-11 06:37:27 -07:00
..
2026-09-09 21:35:08 -04:00
2026-09-11 01:40:43 -04:00
2026-09-09 11:27:36 +10:00
2026-09-03 03:31:03 -07:00
2026-09-11 19:04:06 +10:00
2026-09-11 15:45:43 +05:30
2026-09-07 15:16:44 -07:00
2026-09-03 09:44:26 -07:00
2026-09-03 15:07:39 -07:00
2026-09-07 08:06:48 -07:00
2026-09-03 15:07:39 -07:00
2026-09-03 02:46:19 -07:00
2026-09-07 06:13:16 -07:00
2026-09-07 08:21:24 -07:00
2026-09-11 19:04:06 +10:00
2026-09-03 17:13:22 -07:00
2026-09-02 21:00:34 -07:00
2026-09-11 03:45:33 +05:30
2026-09-11 03:45:33 +05:30
2026-09-11 03:45:33 +05:30
2026-09-11 03:45:33 +05:30
2026-09-03 13:49:57 -07:00
2026-09-02 20:56:23 -07:00
2026-09-03 13:49:57 -07:00
2026-09-05 18:08:00 +05:30
2026-09-02 22:51:30 -07:00
2026-09-09 10:14:58 -07:00
2026-09-11 03:45:31 +05:30
2026-09-11 03:45:33 +05:30
2026-09-11 03:45:33 +05:30
2026-09-03 13:08:40 -07:00
2026-09-03 13:48:49 -07:00
2026-09-11 03:45:33 +05:30
2026-09-09 21:17:35 +05:30
2026-09-03 13:08:40 -07:00
2026-09-02 21:59:38 -07:00
2026-09-03 13:08:40 -07:00
2026-09-02 21:59:38 -07:00
2026-09-11 19:04:06 +10:00
2026-09-02 20:34:28 -07:00
2026-09-11 11:14:56 +05:30
2026-09-03 02:07:33 -07:00
2026-09-10 18:15:54 -07:00
2026-09-02 21:26:16 -07:00
2026-09-08 05:10:57 -07:00
2026-09-02 23:58:31 -07:00
2026-09-02 23:58:31 -07:00
2026-09-08 03:06:30 -07:00
2026-09-04 00:15:16 -07:00
2026-09-03 13:05:57 -07:00
2026-09-11 03:45:33 +05:30
2026-09-02 21:14:52 -07:00
2026-09-10 11:48:01 -07:00
2026-09-11 03:45:33 +05:30
2026-09-11 19:04:06 +10:00
2026-09-05 06:24:06 -07:00
2026-09-10 11:48:01 -07:00
2026-09-09 12:41:07 +05:30
2026-09-02 21:23:44 -07:00
2026-09-07 08:27:07 -07:00
2026-09-11 06:24:54 -07:00
2026-09-07 08:13:01 -07:00
2026-09-09 15:20:13 -07:00
2026-09-08 13:39:17 -07:00
2026-09-08 13:39:17 -07:00
2026-09-10 11:48:01 -07:00
2026-09-03 13:30:31 -07:00
2026-09-11 19:04:06 +10:00
2026-09-02 23:58:31 -07:00
2026-09-07 21:43:54 +05:30
2026-09-03 09:44:26 -07:00
2026-09-02 21:03:13 -07:00
2026-09-02 15:03:42 -07:00
2026-09-11 19:04:06 +10:00
2026-09-11 19:04:06 +10:00
2026-09-11 19:04:06 +10:00
2026-09-03 00:06:54 -07:00
2026-09-09 02:36:00 -07:00
2026-09-11 02:07:48 -07:00
2026-09-07 04:46:37 -07:00
2026-09-09 04:32:13 -07:00
2026-09-10 01:08:18 -07:00
2026-09-10 02:21:16 +05:30
2026-09-07 08:06:48 -07:00
2026-09-03 09:44:26 -07:00
2026-09-02 20:47:14 -07:00
2026-09-03 03:31:03 -07:00
2026-09-03 09:44:26 -07:00
2026-09-07 16:48:29 -07:00
2026-09-03 00:02:56 -07:00
2026-09-05 16:45:59 +05:30
2026-09-03 15:07:39 -07:00
2026-09-03 00:04:40 -07:00
2026-09-09 10:54:34 -07:00
2026-09-03 09:44:26 -07:00
2026-09-03 14:16:54 -07:00
2026-09-10 01:25:45 -07:00
2026-09-03 00:06:30 -07:00
2026-09-04 00:15:16 -07:00
2026-09-04 01:28:31 -07:00
2026-09-03 13:16:47 -07:00
2026-09-03 17:13:22 -07:00
2026-09-03 13:29:35 -07:00
2026-09-03 00:05:41 -07:00
2026-09-11 06:37:27 -07:00
2026-09-05 19:01:22 +05:30
2026-09-04 01:28:31 -07:00
2026-09-04 07:17:00 -07:00
2026-09-10 18:13:16 -07:00
2026-09-06 05:41:46 -07:00
2026-09-02 21:20:42 -07:00
2026-09-03 17:13:22 -07:00
2026-09-06 09:09:41 -07:00
2026-09-06 09:09:41 -07:00
2026-09-11 03:45:33 +05:30
2026-09-02 20:40:51 -07:00
2026-09-03 09:44:26 -07:00
2026-09-10 02:48:21 -07:00
2026-09-10 01:00:19 -07:00
2026-09-11 02:06:32 -07:00
2026-09-07 00:51:41 -07:00
2026-09-10 02:44:26 -07:00
2026-09-03 00:06:30 -07:00
2026-09-06 07:20:24 -07:00
2026-09-02 20:06:17 -07:00
2026-09-03 00:06:30 -07:00
2026-09-02 21:20:42 -07:00
2026-09-03 00:06:30 -07:00
2026-09-03 00:10:28 -07:00
2026-09-11 03:45:32 +05:30
2026-09-03 17:13:22 -07:00
2026-09-03 13:48:14 -07:00
2026-09-07 14:16:57 -07:00
2026-09-08 22:35:39 +05:30
2026-09-07 14:16:57 -07:00
2026-09-07 14:16:57 -07:00
2026-09-03 13:48:14 -07:00
2026-09-09 12:18:58 -07:00
2026-09-07 07:09:59 -07:00
2026-09-03 17:13:22 -07:00
2026-09-07 06:04:06 -07:00
2026-09-07 04:46:54 -07:00
2026-09-09 12:18:58 -07:00
2026-09-07 04:46:54 -07:00
2026-09-07 04:46:54 -07:00
2026-09-03 13:48:14 -07:00
2026-09-09 12:18:58 -07:00
2026-09-03 13:48:14 -07:00
2026-09-09 12:18:58 -07:00
2026-09-02 20:12:36 -07:00
2026-09-07 04:55:17 -07:00
2026-09-02 20:15:37 -07:00
2026-09-03 09:44:26 -07:00
2026-09-03 09:44:26 -07:00
2026-09-03 15:07:39 -07:00
2026-09-07 05:56:50 -07:00
2026-09-09 10:28:52 -07:00
2026-09-05 15:02:53 +02:00
2026-09-03 13:33:47 -07:00
2026-09-11 03:45:31 +05:30
2026-09-09 10:26:06 -07:00
2026-09-03 15:07:39 -07:00
2026-09-11 19:04:06 +10:00
2026-09-02 21:44:59 -07:00
2026-09-05 15:02:53 +02:00
2026-09-10 01:00:19 -07:00
2026-09-07 08:22:35 -07:00
2026-09-04 00:15:16 -07:00
2026-09-03 17:13:22 -07:00
2026-09-10 18:12:39 -07:00
2026-09-02 21:44:59 -07:00
2026-09-02 20:50:08 -07:00
2026-09-03 09:44:26 -07:00
2026-09-03 17:13:22 -07:00
2026-09-02 21:44:59 -07:00
2026-09-03 09:44:26 -07:00
2026-09-07 06:15:43 -07:00
2026-09-02 20:51:30 -07:00
2026-09-02 20:51:30 -07:00
2026-09-03 03:31:03 -07:00
2026-09-10 04:22:38 -07:00
2026-09-02 20:51:30 -07:00
2026-09-02 20:51:30 -07:00
2026-09-02 21:54:56 -07:00
2026-09-02 21:54:56 -07:00
2026-09-03 15:07:39 -07:00
2026-09-07 21:22:49 -07:00
2026-09-11 03:45:33 +05:30
2026-09-11 03:45:32 +05:30
2026-09-11 03:45:33 +05:30
2026-09-10 09:22:31 -07:00
2026-09-10 09:11:00 -07:00
2026-09-07 08:08:04 -07:00
2026-09-03 13:48:49 -07:00
2026-09-03 13:48:49 -07:00
2026-09-03 13:48:49 -07:00
2026-09-11 03:45:31 +05:30
2026-09-11 03:45:33 +05:30
2026-09-11 03:45:31 +05:30
2026-09-10 18:11:25 -07:00
2026-09-04 07:17:00 -07:00
2026-09-03 09:44:26 -07:00
2026-09-04 00:15:16 -07:00
2026-09-10 14:56:55 -04:00
2026-09-03 09:44:26 -07:00
2026-09-02 20:40:15 -07:00
2026-09-02 20:24:29 -07:00
2026-09-02 20:40:15 -07:00
2026-09-03 17:13:22 -07:00
2026-09-02 20:19:57 -07:00
2026-09-02 21:57:39 -07:00
2026-09-09 04:38:01 -07:00
2026-09-04 04:56:11 -07:00
2026-09-03 14:00:59 -07:00
2026-09-09 04:38:01 -07:00
2026-09-09 04:38:01 -07:00
2026-09-09 04:38:01 -07:00
2026-09-10 05:09:15 -07:00
2026-09-03 00:09:39 -07:00
2026-09-07 13:11:36 +05:30
2026-09-06 13:36:12 -07:00
2026-09-09 04:38:01 -07:00
2026-09-09 04:38:01 -07:00
2026-09-03 09:44:26 -07:00
2026-09-10 18:13:16 -07:00
2026-09-11 03:45:31 +05:30
2026-09-03 09:44:26 -07:00
2026-09-09 04:27:24 -07:00
2026-09-06 05:34:01 -07:00
2026-09-10 01:00:19 -07:00
2026-09-11 06:24:11 -07:00
2026-09-03 00:06:57 -07:00
2026-09-03 13:46:50 -07:00
2026-09-02 21:07:16 -07:00
2026-09-02 21:07:16 -07:00
2026-09-02 22:55:15 -07:00
2026-09-10 14:56:55 -04:00
2026-09-02 21:09:53 -07:00
2026-09-02 21:00:55 -07:00
2026-09-07 02:09:34 -07:00
2026-09-04 20:24:24 -04:00
2026-09-09 11:31:10 -07:00
2026-09-02 21:00:55 -07:00
2026-09-02 20:47:24 -07:00
2026-09-02 21:00:55 -07:00
2026-09-02 22:39:49 -07:00
2026-09-10 18:08:16 -07:00
2026-09-11 02:49:36 -04:00
2026-09-10 14:56:55 -04:00
2026-09-02 22:25:24 -07:00
2026-09-03 14:00:59 -07:00
2026-09-03 17:13:22 -07:00
2026-09-02 21:07:16 -07:00
2026-09-02 21:07:16 -07:00
2026-09-02 22:33:08 -07:00
2026-09-03 09:44:26 -07:00
2026-09-11 06:24:54 -07:00
2026-09-11 06:24:54 -07:00
2026-09-11 06:24:54 -07:00
2026-09-11 06:24:54 -07:00
2026-09-03 00:06:57 -07:00
2026-09-11 06:37:27 -07:00
2026-09-02 23:59:27 -07:00
2026-09-11 06:37:27 -07:00
2026-09-09 13:30:28 -07:00
2026-09-11 06:24:54 -07:00
2026-09-11 06:24:54 -07:00
2026-09-02 22:39:06 -07:00
2026-09-03 13:33:10 -07:00
2026-09-03 09:44:26 -07:00
2026-09-11 19:04:06 +10:00
2026-09-04 07:17:00 -07:00
2026-09-03 13:33:10 -07:00
2026-09-03 13:33:10 -07:00
2026-09-03 00:11:01 -07:00
2026-09-09 03:32:58 -07:00
2026-09-07 22:25:12 -07:00
2026-09-02 20:43:25 -07:00
2026-09-03 13:08:40 -07:00
2026-09-07 05:59:43 -07:00
2026-09-03 09:44:26 -07:00
2026-09-08 03:06:30 -07:00
2026-09-03 17:13:22 -07:00
2026-09-02 23:04:20 -07:00
2026-09-02 20:59:41 -07:00
2026-09-03 17:13:22 -07:00
2026-09-03 09:44:26 -07:00
2026-09-11 03:45:31 +05:30
2026-09-04 00:15:16 -07:00
2026-09-02 20:43:25 -07:00
2026-09-02 21:36:24 -07:00
2026-09-02 21:34:25 -07:00
2026-09-03 22:00:01 -07:00
2026-09-02 21:49:33 -07:00
2026-09-02 20:43:25 -07:00
2026-09-11 06:24:54 -07:00
2026-09-02 20:43:25 -07:00
2026-09-08 19:52:26 +05:30
2026-09-03 13:22:51 -07:00
2026-09-03 13:29:35 -07:00
2026-09-03 14:16:54 -07:00
2026-09-03 13:10:38 -07:00
2026-09-10 02:21:16 +05:30
2026-09-02 20:38:18 -07:00
2026-09-02 21:31:17 -07:00
2026-09-09 09:19:36 -07:00
2026-09-03 09:44:26 -07:00
2026-09-02 16:34:55 -07:00
2026-09-03 09:44:26 -07:00
2026-09-03 14:27:29 -07:00
2026-09-07 08:20:46 -07:00
2026-09-03 09:44:26 -07:00
2026-09-05 00:24:40 -07:00
2026-09-03 09:44:26 -07:00
2026-09-03 09:44:26 -07:00
2026-09-03 09:44:26 -07:00
2026-09-11 02:06:32 -07:00
2026-09-02 21:49:26 -07:00
2026-09-06 20:47:52 +05:30
2026-09-02 21:45:19 -07:00
2026-09-06 14:53:33 +05:30
2026-09-02 22:12:58 -07:00
2026-09-02 21:28:23 -07:00
2026-09-10 11:48:01 -07:00
2026-09-02 21:28:23 -07:00
2026-09-02 21:28:23 -07:00
2026-09-03 13:20:22 -07:00
2026-09-03 17:13:22 -07:00
2026-09-03 09:44:26 -07:00
2026-09-11 19:04:06 +10:00
2026-09-09 21:16:40 +05:30
2026-09-04 20:24:24 -04:00
2026-09-10 03:58:37 -07:00
2026-09-09 12:17:13 +05:30
2026-09-09 04:38:01 -07:00
2026-09-07 07:11:36 -07:00
2026-09-03 14:21:32 -07:00
2026-09-05 20:44:51 +05:30
2026-09-11 06:21:48 -07:00
2026-09-03 14:21:32 -07:00
2026-09-03 14:21:32 -07:00
2026-09-03 14:21:32 -07:00
2026-09-11 03:45:33 +05:30
2026-09-07 05:56:33 -07:00
2026-09-07 04:56:38 -07:00
2026-09-11 19:04:06 +10:00
2026-09-04 00:15:16 -07:00
2026-09-04 20:24:24 -04:00
2026-09-02 23:08:44 -07:00
2026-09-02 23:08:44 -07:00
2026-09-03 13:05:57 -07:00
2026-09-03 09:44:26 -07:00
2026-09-02 21:54:36 -07:00
2026-09-09 02:36:00 -07:00