teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
44 lines
2.0 KiB
Python
44 lines
2.0 KiB
Python
"""Only new, contentless ACP sessions are ephemeral; existing state remains durable."""
|
|
import json
|
|
from types import SimpleNamespace
|
|
|
|
from acp_adapter.session import SessionManager
|
|
from hermes_state import SessionDB
|
|
|
|
|
|
def test_new_session_persists_only_when_content_exists(tmp_path):
|
|
db = SessionDB(tmp_path / "state.db")
|
|
manager = SessionManager(db=db, agent_factory=lambda: SimpleNamespace(model="fixture"))
|
|
state = manager.create_session(cwd=str(tmp_path))
|
|
assert db.get_session(state.session_id) is None
|
|
manager.update_cwd(state.session_id, str(tmp_path / "moved"))
|
|
manager.save_session(state.session_id)
|
|
empty_fork = manager.fork_session(state.session_id)
|
|
assert db.get_session(state.session_id) is None
|
|
assert db.get_session(empty_fork.session_id) is None
|
|
state.history.append({"role": "user", "content": "kept content"})
|
|
manager.save_session(state.session_id)
|
|
fork = manager.fork_session(state.session_id)
|
|
for sid in (state.session_id, fork.session_id):
|
|
assert db.get_session(sid)["source"] == "acp"
|
|
assert db.get_messages_as_conversation(sid)[0]["content"] == "kept content"
|
|
db.close()
|
|
|
|
|
|
def test_existing_empty_history_still_updates_metadata(tmp_path):
|
|
db = SessionDB(tmp_path / "state.db")
|
|
manager = SessionManager(db=db, agent_factory=lambda: SimpleNamespace(model="fixture"))
|
|
# An old, unprompted ACP client may still own its row: source is not liveness.
|
|
db.create_session(session_id="existing", source="acp", model="original")
|
|
state = manager.get_session("existing")
|
|
assert state is not None
|
|
assert not state.history
|
|
state.model = "selected-model"
|
|
manager.update_cwd(state.session_id, str(tmp_path / "selected"))
|
|
row = db.get_session(state.session_id)
|
|
assert row["model"] == "selected-model"
|
|
assert json.loads(row["model_config"])["cwd"] == state.cwd
|
|
assert manager.get_session(state.session_id) is state
|
|
assert db.list_never_active_keyed_sessions(older_than_days=0) == []
|
|
db.close()
|