teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
38 lines
1.5 KiB
Python
38 lines
1.5 KiB
Python
"""Guardrail: _create_openai_client must not mutate its input kwargs.
|
|
|
|
#10933 injected an httpx.Client directly into the caller's ``client_kwargs``.
|
|
When the dict was ``self._client_kwargs``, the shared transport was torn down
|
|
after the first request_complete close and subsequent request-scoped clients
|
|
wrapped a closed transport, raising ``APIConnectionError('Connection error.')``
|
|
with cause ``RuntimeError: Cannot send a request, as the client has been closed``
|
|
on every retry. That PR has since been reverted, but the underlying issue
|
|
(#10324, connections hanging in CLOSE-WAIT) is still open, so another transport
|
|
tweak inside this function is likely. This test pins the contract that the
|
|
function must treat its input dict as read-only.
|
|
"""
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
@patch("agent.process_bootstrap.OpenAI")
|
|
def test_create_openai_client_does_not_mutate_input_kwargs(mock_openai):
|
|
mock_openai.return_value = MagicMock()
|
|
agent = AIAgent(
|
|
api_key="test-key",
|
|
base_url="https://openrouter.ai/api/v1",
|
|
model="test/model",
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=True,
|
|
)
|
|
|
|
kwargs = {"api_key": "test-key", "base_url": "https://api.example.com/v1"}
|
|
snapshot = dict(kwargs)
|
|
|
|
agent._create_openai_client(kwargs, reason="test", shared=False)
|
|
|
|
assert kwargs == snapshot, (
|
|
f"_create_openai_client mutated input kwargs; expected {snapshot}, got {kwargs}"
|
|
)
|