teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
65 lines
2.4 KiB
Python
65 lines
2.4 KiB
Python
"""Tests for the display.credits_notices config gate on _emit_credits_notices.
|
|
|
|
The toggle suppresses notice EMISSION only — credits state capture and /usage
|
|
stay live. Uses the bare-AIAgent pattern (object.__new__) from test_notice_spine.py.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import patch
|
|
|
|
from agent.credits_tracker import CreditsState
|
|
from run_agent import AIAgent
|
|
|
|
|
|
def _agent_with_state(*, paid_access: bool = False) -> AIAgent:
|
|
"""Bare agent with a depleted-shaped state that would normally emit."""
|
|
agent = object.__new__(AIAgent)
|
|
agent.notice_callback = None
|
|
agent.notice_clear_callback = None
|
|
agent._credits_state = CreditsState(paid_access=paid_access)
|
|
agent.model = ""
|
|
agent.base_url = ""
|
|
return agent
|
|
|
|
|
|
def _cfg(enabled):
|
|
return {"display": {"credits_notices": enabled}}
|
|
|
|
|
|
class TestCreditsNoticesToggle:
|
|
def test_disabled_emits_nothing(self):
|
|
agent = _agent_with_state()
|
|
received = []
|
|
agent.notice_callback = received.append
|
|
with patch("hermes_cli.config.load_config", return_value=_cfg(False)):
|
|
agent._emit_credits_notices()
|
|
assert received == []
|
|
|
|
|
|
|
|
def test_config_error_fails_open(self):
|
|
agent = _agent_with_state()
|
|
received = []
|
|
agent.notice_callback = received.append
|
|
with patch("hermes_cli.config.load_config", side_effect=RuntimeError("boom")):
|
|
agent._emit_credits_notices()
|
|
assert any(getattr(n, "key", None) == "credits.depleted" for n in received)
|
|
|
|
def test_toggle_cached_per_agent(self):
|
|
"""load_config is consulted once per agent, not once per emission."""
|
|
agent = _agent_with_state()
|
|
agent.notice_callback = lambda n: None
|
|
with patch("hermes_cli.config.load_config", return_value=_cfg(True)) as mock_load:
|
|
agent._emit_credits_notices()
|
|
agent._emit_credits_notices()
|
|
assert mock_load.call_count == 1
|
|
|
|
def test_disabled_state_still_cached_for_usage(self):
|
|
"""The gate stops emission only — get_credits_state still returns data."""
|
|
agent = _agent_with_state()
|
|
agent.notice_callback = lambda n: None
|
|
agent._credits_session_start_micros = None
|
|
with patch("hermes_cli.config.load_config", return_value=_cfg(False)):
|
|
agent._emit_credits_notices()
|
|
assert agent.get_credits_state() is not None
|