teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
67 lines
2.3 KiB
Python
67 lines
2.3 KiB
Python
"""Regression tests for hermetic guards around local desktop side effects."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import webbrowser
|
|
|
|
|
|
def test_webbrowser_open_calls_are_neutralized(monkeypatch):
|
|
"""OAuth/browser tests should never reach the real browser registry."""
|
|
|
|
def _real_browser_lookup_reached(*_args, **_kwargs):
|
|
raise AssertionError("test reached the real webbrowser registry")
|
|
|
|
monkeypatch.setattr(webbrowser, "get", _real_browser_lookup_reached)
|
|
|
|
url = "https://provider.example.invalid/oauth/authorize"
|
|
|
|
assert webbrowser.open(url) is True
|
|
assert webbrowser.open_new(url) is True
|
|
assert webbrowser.open_new_tab(url) is True
|
|
|
|
|
|
def test_webbrowser_get_controller_is_neutralized(_neutralize_webbrowser):
|
|
"""Direct controller access should still stay inside the test recorder."""
|
|
url = "https://provider.example.invalid/oauth/authorize"
|
|
|
|
controller = webbrowser.get("hermes-test-browser")
|
|
|
|
assert controller.open(url) is True
|
|
assert controller.open_new(url) is True
|
|
assert controller.open_new_tab(url) is True
|
|
assert _neutralize_webbrowser == [url, url, url]
|
|
|
|
|
|
def _isolate_anthropic_credentials(monkeypatch, tmp_path):
|
|
from agent import anthropic_credentials as ac
|
|
|
|
monkeypatch.delenv("ANTHROPIC_API_KEY", raising=False)
|
|
monkeypatch.delenv("ANTHROPIC_TOKEN", raising=False)
|
|
monkeypatch.delenv("CLAUDE_CODE_OAUTH_TOKEN", raising=False)
|
|
monkeypatch.setattr(ac.Path, "home", lambda: tmp_path)
|
|
monkeypatch.setattr(ac.platform, "system", lambda: "Darwin")
|
|
|
|
def _real_keychain_reached(*_args, **_kwargs):
|
|
raise AssertionError("test reached the real macOS Keychain command")
|
|
|
|
monkeypatch.setattr(ac.subprocess, "run", _real_keychain_reached)
|
|
return ac
|
|
|
|
|
|
def test_claude_code_credential_read_does_not_touch_macos_keychain(
|
|
monkeypatch, tmp_path
|
|
):
|
|
"""The real credential reader should be safe under the suite guard."""
|
|
ac = _isolate_anthropic_credentials(monkeypatch, tmp_path)
|
|
|
|
assert ac.read_claude_code_credentials() is None
|
|
|
|
|
|
def test_anthropic_token_resolution_does_not_touch_macos_keychain(
|
|
monkeypatch, tmp_path
|
|
):
|
|
"""Token resolution should be safe under the same suite guard."""
|
|
ac = _isolate_anthropic_credentials(monkeypatch, tmp_path)
|
|
|
|
assert ac.resolve_anthropic_token() is None
|