teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
140 lines
4.4 KiB
Python
140 lines
4.4 KiB
Python
"""Regression tests for the notice-spine (AgentNotice + emitter callbacks).
|
|
|
|
Covers:
|
|
A. _emit_notice / _emit_notice_clear emitter behaviour (bare AIAgent via
|
|
object.__new__ — same pattern as test_steer.py and test_file_mutation_verifier.py).
|
|
B. Constructor / init_agent signature threading.
|
|
C. TUI _agent_cbs notice binding — mirrors the status_callback tests already
|
|
in tests/tui_gateway/test_tui_gateway_server.py.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import inspect
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from agent.credits_tracker import AgentNotice
|
|
from run_agent import AIAgent
|
|
|
|
|
|
# ── A. Emitter behaviour ─────────────────────────────────────────────────────
|
|
|
|
|
|
def _bare_agent() -> AIAgent:
|
|
"""Build an AIAgent without running __init__ (no heavy init required).
|
|
|
|
Only the two callback slots used by _emit_notice / _emit_notice_clear are
|
|
installed — mirrors the pattern in test_steer.py.
|
|
"""
|
|
agent = object.__new__(AIAgent)
|
|
agent.notice_callback = None
|
|
agent.notice_clear_callback = None
|
|
return agent
|
|
|
|
|
|
class TestEmitNotice:
|
|
def test_emit_notice_calls_callback_with_exact_notice(self):
|
|
agent = _bare_agent()
|
|
received = []
|
|
notice = AgentNotice(
|
|
text="credits 90% used",
|
|
level="warn",
|
|
kind="sticky",
|
|
ttl_ms=None,
|
|
key="credits.warn90",
|
|
id="n1",
|
|
)
|
|
agent.notice_callback = received.append
|
|
agent._emit_notice(notice)
|
|
assert received == [notice]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ── B. Constructor / init_agent signature threading ─────────────────────────
|
|
|
|
|
|
class TestSignatureThreading:
|
|
def test_agent_init_exposes_notice_callback(self):
|
|
sig = inspect.signature(AIAgent.__init__)
|
|
assert "notice_callback" in sig.parameters
|
|
|
|
|
|
|
|
|
|
|
|
# ── C. TUI _agent_cbs binding ────────────────────────────────────────────────
|
|
|
|
|
|
class TestAgentCbsNoticeBinding:
|
|
"""Mirror test_status_callback_emits_kind_and_text from test_tui_gateway_server.py."""
|
|
|
|
def test_notice_callback_emits_notification_show(self):
|
|
from tui_gateway import server
|
|
|
|
with patch("tui_gateway.server._emit") as mock_emit:
|
|
cbs = server._agent_cbs("sid123")
|
|
notice = AgentNotice(
|
|
text="credits 90% used",
|
|
level="warn",
|
|
kind="sticky",
|
|
ttl_ms=None,
|
|
key="credits.warn90",
|
|
id="n1",
|
|
)
|
|
cbs["notice_callback"](notice)
|
|
|
|
mock_emit.assert_called_once_with(
|
|
"notification.show",
|
|
"sid123",
|
|
{
|
|
"text": "credits 90% used",
|
|
"level": "warn",
|
|
"kind": "sticky",
|
|
"ttl_ms": None,
|
|
"key": "credits.warn90",
|
|
"id": "n1",
|
|
},
|
|
)
|
|
|
|
def test_notice_callback_payload_is_full_snake_case_dict(self):
|
|
"""All six snake_case fields must be present in the payload — no extras,
|
|
no camelCase variants."""
|
|
from tui_gateway import server
|
|
|
|
captured = []
|
|
with patch("tui_gateway.server._emit", side_effect=lambda *a: captured.append(a)):
|
|
cbs = server._agent_cbs("sid123")
|
|
cbs["notice_callback"](
|
|
AgentNotice(
|
|
text="credits 90% used",
|
|
level="warn",
|
|
kind="sticky",
|
|
ttl_ms=None,
|
|
key="credits.warn90",
|
|
id="n1",
|
|
)
|
|
)
|
|
|
|
assert len(captured) == 1
|
|
_event_type, _sid, payload = captured[0]
|
|
assert set(payload.keys()) == {"text", "level", "kind", "ttl_ms", "key", "id"}
|
|
|
|
|
|
|
|
def test_notice_clear_callback_event_type_is_notification_clear(self):
|
|
from tui_gateway import server
|
|
|
|
captured = []
|
|
with patch("tui_gateway.server._emit", side_effect=lambda *a: captured.append(a)):
|
|
cbs = server._agent_cbs("sid123")
|
|
cbs["notice_clear_callback"]("some.key")
|
|
|
|
assert captured[0][0] == "notification.clear"
|
|
assert captured[0][1] == "sid123"
|
|
assert captured[0][2] == {"key": "some.key"}
|