teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
62 lines
1.4 KiB
Python
62 lines
1.4 KiB
Python
"""Tests for _repair_tool_call_arguments — malformed JSON repair pipeline."""
|
|
|
|
import json
|
|
|
|
from agent.message_sanitization import _repair_tool_call_arguments
|
|
class TestRepairToolCallArguments:
|
|
"""Verify each repair stage in the pipeline."""
|
|
|
|
# -- Stage 1: empty / whitespace-only --
|
|
|
|
def test_empty_string_returns_empty_object(self):
|
|
assert _repair_tool_call_arguments("", "t") == "{}"
|
|
|
|
|
|
|
|
# -- Stage 2: Python None literal --
|
|
|
|
|
|
|
|
# -- Stage 3: trailing comma repair --
|
|
|
|
|
|
def test_trailing_comma_in_array(self):
|
|
result = _repair_tool_call_arguments('{"a": [1, 2,]}', "t")
|
|
parsed = json.loads(result)
|
|
assert parsed == {"a": [1, 2]}
|
|
|
|
|
|
# -- Stage 4: unclosed brackets --
|
|
|
|
|
|
|
|
# -- Stage 5: excess closing delimiters --
|
|
|
|
|
|
|
|
# -- Stage 6: last resort --
|
|
|
|
|
|
def test_unrepairable_partial_returns_empty_object(self):
|
|
# Truncated in the middle of a string key — bracket closing won't help
|
|
assert _repair_tool_call_arguments('{"truncated": "val', "t") == "{}"
|
|
|
|
# -- Valid JSON passthrough (this path is via except, but still works) --
|
|
|
|
|
|
# -- Combined repairs --
|
|
|
|
|
|
|
|
# -- Stage 0: strict=False (literal control chars in strings) --
|
|
# llama.cpp backends sometimes emit literal tabs/newlines inside JSON
|
|
# string values. strict=False accepts these; we re-serialise to the
|
|
# canonical wire form (#12068).
|
|
|
|
|
|
|
|
|
|
# -- Stage 4: control-char escape fallback --
|
|
|
|
|