Files
hermes-agent/tests/gateway/test_priority_path_compression_demotion.py
T
teknium1 d10bb2ab6f test: make tests/ mirror the source tree; drop issue numbers from filenames
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.

Parallel directories for one source package, folded into the mirror:
  tests/acp        -> tests/acp_adapter   (its __init__/conftest move with it)
  tests/cli        -> tests/hermes_cli    (prompt_toolkit fixture merged into
                                           hermes_cli/conftest.py)
  tests/run_agent  -> tests/agent         (backoff fixture becomes
                                           agent/conftest.py)
  tests/relay      -> tests/gateway/relay
  tests/state      -> tests/hermes_state

246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.

Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.

Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).

Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
2026-09-13 09:18:02 -07:00

150 lines
5.8 KiB
Python

"""Regression test: the ``_handle_message`` PRIORITY busy-path must also
demote ``busy_input_mode='interrupt'`` to queue semantics when context
compression is in flight (#56391), the same as
``_handle_active_session_busy_message`` already does.
Both code paths handle a message arriving while an agent is already running
for the session. ``_handle_active_session_busy_message`` (the
``busy_session_handler`` callback most platform adapters register via
``gateway/platforms/base.py``) demotes ``interrupt`` -> ``queue`` for two
independent reasons:
* active subagents (#30170)
* context compression in flight (#56391)
``_handle_message`` has its own, independent inline "PRIORITY" busy-handling
block (see the ``if _quick_key in self._running_agents:`` guard) that a
plain-text follow-up reaches directly — mirrors_test_running_agent_session_
toggles.py already proves ``_handle_message`` is invoked directly with an
active running agent, not only through the adapter dispatch layer. That
PRIORITY block's own comment says it mirrors
``_handle_active_session_busy_message``'s subagent-demotion rationale
verbatim, and it does demote for active subagents — but it never checks
``_session_has_compression_in_flight``, so a plain-text follow-up landing on
this path while compression is mid-flight still interrupts, racing a new
turn against the pre-rotation parent session exactly as #56391 describes.
"""
from datetime import datetime
from types import SimpleNamespace
from unittest.mock import AsyncMock, MagicMock
import pytest
from gateway.config import GatewayConfig, Platform, PlatformConfig
from gateway.platforms.event import MessageEvent
from gateway.session import SessionEntry, SessionSource, build_session_key
def _make_source() -> SessionSource:
return SessionSource(
platform=Platform.TELEGRAM,
user_id="u1",
chat_id="c1",
user_name="tester",
chat_type="dm",
)
def _make_event(text: str) -> MessageEvent:
return MessageEvent(text=text, source=_make_source(), message_id="m1")
def _make_runner(*, compression_in_flight: bool):
"""Minimal GatewayRunner with an active running agent for this session.
Mirrors tests/gateway/test_running_agent_session_toggles.py's harness
(proven to drive _handle_message end-to-end with a live running agent),
extended with the compression-lock plumbing
_session_has_compression_in_flight reads.
"""
from gateway.run import GatewayRunner
runner = object.__new__(GatewayRunner)
runner.config = GatewayConfig(
platforms={Platform.TELEGRAM: PlatformConfig(enabled=True, token="***")}
)
adapter = MagicMock()
adapter.send = AsyncMock()
adapter._pending_messages = {}
runner.adapters = {Platform.TELEGRAM: adapter}
runner._voice_mode = {}
runner.hooks = SimpleNamespace(emit=AsyncMock(), loaded_hooks=False)
source = _make_source()
sk = build_session_key(source)
session_entry = SessionEntry(
session_key=sk,
session_id="sess-1",
created_at=datetime.now(),
updated_at=datetime.now(),
platform=Platform.TELEGRAM,
chat_type="dm",
)
session_store = MagicMock()
session_store.get_or_create_session.return_value = session_entry
session_store.load_transcript.return_value = []
session_store.has_any_sessions.return_value = True
session_store.append_to_transcript = MagicMock()
session_store.rewrite_transcript = MagicMock()
session_store.update_session = MagicMock()
runner.session_store = session_store
runner._running_agents = {}
runner._running_agents_ts = {}
runner._pending_messages = {}
runner._pending_approvals = {}
runner._session_db = None
runner._reasoning_config = None
runner._provider_routing = {}
runner._fallback_model = None
runner._show_reasoning = False
runner._service_tier = None
runner._is_user_authorized = lambda _source: True
runner._set_session_env = lambda _context: None
runner._should_send_voice_reply = lambda *_args, **_kwargs: False
runner._send_voice_reply = AsyncMock()
runner._capture_gateway_honcho_if_configured = lambda *args, **kwargs: None
runner._emit_gateway_run_progress = AsyncMock()
runner._draining = False
runner._busy_input_mode = "interrupt"
# No subagents active — isolates the compression-demotion behavior from
# the (already-correct) subagent-demotion branch.
runner._agent_has_active_subagents = lambda _agent: False
runner._session_has_compression_in_flight = AsyncMock(
return_value=compression_in_flight
)
import time
agent_mock = MagicMock()
agent_mock.get_activity_summary.return_value = {
"seconds_since_activity": 0.0,
"last_activity_desc": "api_call",
"api_call_count": 1,
"max_iterations": 60,
}
runner._running_agents[sk] = agent_mock
# Past the Telegram follow-up grace window (HERMES_TELEGRAM_FOLLOWUP_
# GRACE_SECONDS, default 3.0s) so the message reaches the PRIORITY
# interrupt/steer/subagent-demotion block instead of the earlier
# "just started, queue without interrupt" grace-period branch.
runner._running_agents_ts[sk] = time.time() - 120
return runner, agent_mock, sk
@pytest.mark.asyncio
async def test_priority_path_does_not_interrupt_when_compression_in_flight():
"""A plain-text follow-up must NOT interrupt the running agent while
context compression is in flight — it must queue instead, mirroring
_handle_active_session_busy_message's #56391 demotion."""
runner, agent_mock, sk = _make_runner(compression_in_flight=True)
await runner._handle_message(_make_event("still there?"))
agent_mock.interrupt.assert_not_called()
queued = runner.adapters[Platform.TELEGRAM]._pending_messages.get(sk)
assert queued is not None and queued.text == "still there?"