teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
94 lines
3.8 KiB
Python
94 lines
3.8 KiB
Python
"""Issue #76423 — Gateway routes source.profile into telegram topic state."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
from hermes_state import SessionDB
|
|
from gateway.config import Platform
|
|
from gateway.session import SessionSource
|
|
|
|
|
|
CHAT = "208214988"
|
|
|
|
|
|
def _source(profile=None, thread_id="42"):
|
|
return SessionSource(
|
|
platform=Platform.TELEGRAM,
|
|
user_id=CHAT,
|
|
chat_id=CHAT,
|
|
user_name="tester",
|
|
chat_type="dm",
|
|
thread_id=thread_id,
|
|
profile=profile,
|
|
)
|
|
|
|
|
|
def test_gateway_uses_source_profile_not_global(tmp_path: Path):
|
|
from gateway.run import GatewayRunner
|
|
|
|
assert GatewayRunner._telegram_topic_profile_name(_source("coder")) == "coder"
|
|
assert GatewayRunner._telegram_topic_profile_name(_source(None)) == "default"
|
|
|
|
db = SessionDB(db_path=tmp_path / "state.db")
|
|
db.create_session(session_id="sess-coder", source="telegram", user_id=CHAT, profile_name="coder")
|
|
db.enable_telegram_topic_mode(chat_id=CHAT, user_id=CHAT, profile_name="coder")
|
|
|
|
runner = object.__new__(GatewayRunner)
|
|
runner._session_db = db
|
|
assert runner._telegram_topic_mode_enabled(_source("coder")) is True
|
|
assert runner._telegram_topic_mode_enabled(_source("other")) is False
|
|
assert runner._telegram_topic_mode_enabled(_source(None)) is False
|
|
|
|
runner._record_telegram_topic_binding(
|
|
_source("coder", "42"),
|
|
SimpleNamespace(session_key="k", session_id="sess-coder"),
|
|
)
|
|
assert db.get_telegram_topic_binding(
|
|
chat_id=CHAT, thread_id="42", profile_name="coder",
|
|
) is not None
|
|
assert db.get_telegram_topic_binding(
|
|
chat_id=CHAT, thread_id="42", profile_name="default",
|
|
) is None
|
|
db.close()
|
|
|
|
|
|
def test_routed_profile_flows_into_prune_via_send_metadata(tmp_path: Path):
|
|
"""profile_routes: the transport adapter may be the primary (default) bot
|
|
while the turn is routed to another profile — the outbound metadata built
|
|
by the gateway carries the routed profile, and prune uses it over the
|
|
adapter's own stamp (#76423)."""
|
|
from gateway.run import GatewayRunner
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
|
|
runner = object.__new__(GatewayRunner)
|
|
runner._thread_metadata_for_target = lambda *a, **k: {"thread_id": "99"}
|
|
meta = runner._thread_metadata_for_source(_source("coder", "99"))
|
|
assert meta["hermes_profile"] == "coder"
|
|
assert "hermes_profile" not in runner._thread_metadata_for_source(_source(None, "99"))
|
|
|
|
# Cooldowns are keyed (profile, chat): alpha's reminder must not gag beta.
|
|
assert runner._should_send_telegram_lobby_reminder(_source("alpha")) is True
|
|
assert runner._should_send_telegram_lobby_reminder(_source("beta")) is True
|
|
assert runner._should_send_telegram_lobby_reminder(_source("alpha")) is False
|
|
|
|
db = SessionDB(db_path=tmp_path / "state.db")
|
|
db.create_session(session_id="sess-default", source="telegram", user_id=CHAT)
|
|
db.create_session(session_id="sess-coder", source="telegram", user_id=CHAT, profile_name="coder")
|
|
for prof, sid in (("default", "sess-default"), ("coder", "sess-coder")):
|
|
db.bind_telegram_topic(
|
|
chat_id=CHAT, thread_id="99", user_id=CHAT,
|
|
session_key=f"k-{prof}", session_id=sid, profile_name=prof,
|
|
)
|
|
|
|
adapter = object.__new__(TelegramAdapter)
|
|
adapter.platform = Platform.TELEGRAM
|
|
adapter._session_store = SimpleNamespace(_db=db)
|
|
adapter._hermes_profile_name = "default" # transport = primary bot
|
|
adapter._prune_stale_dm_topic_binding(CHAT, "99", metadata=meta)
|
|
|
|
assert db.get_telegram_topic_binding(chat_id=CHAT, thread_id="99", profile_name="coder") is None
|
|
assert db.get_telegram_topic_binding(chat_id=CHAT, thread_id="99", profile_name="default") is not None
|
|
db.close()
|