teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
135 lines
4.8 KiB
Python
135 lines
4.8 KiB
Python
"""Tests for /save — the conversation snapshot slash command.
|
|
|
|
Regression: the old implementation wrote ``hermes_conversation_<ts>.json``
|
|
to the current working directory (CWD). Users who ran /save expected the
|
|
file to be discoverable via ``hermes sessions browse``, but CWD-resident
|
|
snapshots are not indexed in the state DB and are generally invisible.
|
|
The fix writes snapshots under ``~/.hermes/sessions/saved/`` and prints
|
|
the absolute path plus the resume hint for the live session.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import sys
|
|
from datetime import datetime
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def hermes_home(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
# Clear any cached hermes_home computation
|
|
import hermes_constants
|
|
if hasattr(hermes_constants, "_hermes_home_cache"):
|
|
hermes_constants._hermes_home_cache = None
|
|
return home
|
|
|
|
|
|
def _make_stub_cli(history):
|
|
"""Build a minimal object exposing just what save_conversation uses."""
|
|
return SimpleNamespace(
|
|
conversation_history=history,
|
|
model="test-model",
|
|
session_id="20260101_120000_abc123",
|
|
session_start=datetime(2026, 1, 1, 12, 0, 0),
|
|
)
|
|
|
|
|
|
def test_save_conversation_writes_under_hermes_home(hermes_home, tmp_path, monkeypatch, capsys):
|
|
"""Snapshot must land under ~/.hermes/sessions/saved/, not CWD."""
|
|
# Change CWD to a different directory to prove the file does NOT go there.
|
|
work = tmp_path / "somewhere-else"
|
|
work.mkdir()
|
|
monkeypatch.chdir(work)
|
|
|
|
# Import fresh to pick up the HERMES_HOME fixture
|
|
for mod in [m for m in sys.modules if m.startswith("cli") or m == "hermes_constants"]:
|
|
sys.modules.pop(mod, None)
|
|
|
|
import cli # noqa: F401 (module under test)
|
|
|
|
stub = _make_stub_cli([
|
|
{"role": "user", "content": "hi"},
|
|
{"role": "assistant", "content": "hello"},
|
|
])
|
|
|
|
# Call the unbound method against our stub.
|
|
cli.HermesCLI.save_conversation(stub, "/save json")
|
|
|
|
# File must NOT be in CWD
|
|
cwd_leak = list(work.glob("hermes_conversation_*.json"))
|
|
assert not cwd_leak, f"snapshot leaked to CWD: {cwd_leak}"
|
|
|
|
# File MUST be under ~/.hermes/sessions/saved/
|
|
saved_dir = hermes_home / "sessions" / "saved"
|
|
assert saved_dir.is_dir(), "expected saved/ subdirectory to be created"
|
|
files = list(saved_dir.glob("hermes_conversation_*.json"))
|
|
assert len(files) == 1, files
|
|
|
|
payload = json.loads(files[0].read_text())
|
|
assert payload["model"] == "test-model"
|
|
# /save now emits the canonical export_session shape: the session id
|
|
# lives under "id" (was "session_id" in the legacy snapshot format).
|
|
assert payload["id"] == "20260101_120000_abc123"
|
|
assert payload["messages"] == [
|
|
{"role": "user", "content": "hi"},
|
|
{"role": "assistant", "content": "hello"},
|
|
]
|
|
|
|
# User-facing message must include the absolute path AND the resume hint.
|
|
out = capsys.readouterr().out
|
|
assert str(files[0]) in out, out
|
|
assert "hermes --resume 20260101_120000_abc123" in out, out
|
|
|
|
|
|
def test_save_conversation_empty_history_does_nothing(hermes_home, capsys):
|
|
for mod in [m for m in sys.modules if m.startswith("cli") or m == "hermes_constants"]:
|
|
sys.modules.pop(mod, None)
|
|
import cli
|
|
|
|
stub = _make_stub_cli([])
|
|
cli.HermesCLI.save_conversation(stub, "/save json")
|
|
|
|
saved_dir = hermes_home / "sessions" / "saved"
|
|
assert not saved_dir.exists() or not list(saved_dir.iterdir())
|
|
out = capsys.readouterr().out
|
|
assert "No conversation to save" in out
|
|
|
|
|
|
def test_save_conversation_bare_shows_usage(hermes_home, capsys):
|
|
"""Bare /save prints the usage card and writes nothing."""
|
|
for mod in [m for m in sys.modules if m.startswith("cli") or m == "hermes_constants"]:
|
|
sys.modules.pop(mod, None)
|
|
import cli
|
|
|
|
stub = _make_stub_cli([{"role": "user", "content": "hi"}])
|
|
cli.HermesCLI.save_conversation(stub, "/save")
|
|
|
|
saved_dir = hermes_home / "sessions" / "saved"
|
|
assert not saved_dir.exists() or not list(saved_dir.iterdir())
|
|
out = capsys.readouterr().out
|
|
# Usage card lists every format and the redact option
|
|
for token in ("json", "md", "html", "redact", "Usage:"):
|
|
assert token in out, (token, out)
|
|
|
|
|
|
def test_save_conversation_bad_format_shows_usage(hermes_home, capsys):
|
|
for mod in [m for m in sys.modules if m.startswith("cli") or m == "hermes_constants"]:
|
|
sys.modules.pop(mod, None)
|
|
import cli
|
|
|
|
stub = _make_stub_cli([{"role": "user", "content": "hi"}])
|
|
cli.HermesCLI.save_conversation(stub, "/save pdf")
|
|
|
|
saved_dir = hermes_home / "sessions" / "saved"
|
|
assert not saved_dir.exists() or not list(saved_dir.iterdir())
|
|
out = capsys.readouterr().out
|
|
assert "Usage:" in out
|