teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
108 lines
3.9 KiB
Python
108 lines
3.9 KiB
Python
from unittest.mock import MagicMock, patch
|
|
from types import SimpleNamespace
|
|
from hermes_cli.plugins import VALID_HOOKS, PluginManager
|
|
from cli import HermesCLI
|
|
|
|
|
|
def test_session_hooks_in_valid_hooks():
|
|
"""Verify on_session_finalize and on_session_reset are registered as valid hooks."""
|
|
assert "on_session_finalize" in VALID_HOOKS
|
|
assert "on_session_reset" in VALID_HOOKS
|
|
|
|
|
|
# These tests pin CLI ownership of the finalize request. The end-to-end
|
|
# built-in/core/plugin dispatch order is exercised by
|
|
# tests/hermes_cli/test_lifecycle.py::test_finalize_session_closes_core_before_plugin_export.
|
|
@patch("hermes_cli.lifecycle.invoke_hook")
|
|
@patch("hermes_cli.lifecycle.finalize_session")
|
|
def test_session_finalize_on_reset(mock_finalize_session, mock_invoke_hook):
|
|
"""Verify on_session_finalize fires when /new or /reset is used."""
|
|
cli = HermesCLI()
|
|
cli.agent = MagicMock()
|
|
cli.agent.session_id = "test-session-id"
|
|
|
|
# Simulate /new command which triggers on_session_finalize for the old session
|
|
cli.new_session(silent=True)
|
|
|
|
# Check if on_session_finalize was called for the old session
|
|
assert any(
|
|
not c.args
|
|
and c.kwargs["session_id"] == "test-session-id"
|
|
and c.kwargs["platform"] == "cli"
|
|
for c in mock_finalize_session.call_args_list
|
|
)
|
|
# Check if on_session_reset was called for the new session
|
|
assert any(
|
|
c.args == ("on_session_reset",)
|
|
and c.kwargs["session_id"] == cli.session_id
|
|
and c.kwargs["platform"] == "cli"
|
|
for c in mock_invoke_hook.call_args_list
|
|
)
|
|
|
|
|
|
@patch("hermes_cli.lifecycle.finalize_session")
|
|
def test_session_finalize_on_cleanup(mock_finalize_session):
|
|
"""Verify on_session_finalize fires during CLI exit cleanup."""
|
|
import cli as cli_mod
|
|
|
|
mock_agent = MagicMock()
|
|
mock_agent.session_id = "cleanup-session-id"
|
|
cli_mod._active_agent_ref = mock_agent
|
|
cli_mod._cleanup_done = False
|
|
|
|
cli_mod._run_cleanup()
|
|
|
|
assert any(
|
|
not c.args
|
|
and c.kwargs["session_id"] == "cleanup-session-id"
|
|
and c.kwargs["platform"] == "cli"
|
|
and c.kwargs["reason"] == "shutdown"
|
|
for c in mock_finalize_session.call_args_list
|
|
)
|
|
|
|
|
|
@patch("hermes_cli.lifecycle.invoke_hook")
|
|
def test_interrupted_session_end_helper_emits_observer_shape(mock_invoke_hook):
|
|
"""Verify quiet single-query interruption emits a correlated session end."""
|
|
import cli as cli_mod
|
|
|
|
mock_agent = MagicMock()
|
|
mock_agent.session_id = "agent-session-id"
|
|
mock_agent.model = "test-model"
|
|
mock_agent.platform = "cli"
|
|
mock_agent._current_task_id = "task-1"
|
|
mock_agent._current_turn_id = "turn-1"
|
|
mock_agent._current_api_request_id = "api-1"
|
|
cli = SimpleNamespace(agent=mock_agent, session_id="cli-session-id")
|
|
|
|
cli_mod._emit_interrupted_session_end(cli, reason="keyboard_interrupt")
|
|
|
|
mock_agent.interrupt.assert_called_once_with("keyboard interrupt")
|
|
assert cli.session_id == "agent-session-id"
|
|
mock_invoke_hook.assert_called_once()
|
|
call = mock_invoke_hook.call_args
|
|
assert call.args == ("on_session_end",)
|
|
assert call.kwargs["session_id"] == "agent-session-id"
|
|
assert call.kwargs["task_id"] == "task-1"
|
|
assert call.kwargs["turn_id"] == "turn-1"
|
|
assert call.kwargs["api_request_id"] == "api-1"
|
|
assert call.kwargs["completed"] is False
|
|
assert call.kwargs["interrupted"] is True
|
|
assert call.kwargs["reason"] == "keyboard_interrupt"
|
|
|
|
|
|
@patch("hermes_cli.plugins.invoke_hook")
|
|
def test_hook_errors_are_caught(mock_invoke_hook):
|
|
"""Verify hook exceptions are caught and don't crash the agent."""
|
|
mgr = PluginManager()
|
|
|
|
# Register a hook that raises
|
|
def bad_callback(**kwargs):
|
|
raise Exception("Hook failed")
|
|
|
|
mgr._hooks["on_session_finalize"] = [bad_callback]
|
|
|
|
# This should not raise
|
|
results = mgr.invoke_hook("on_session_finalize", session_id="test", platform="cli")
|
|
assert results == []
|