teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
60 lines
1.8 KiB
Python
60 lines
1.8 KiB
Python
"""CLI freezes UI paints after stdout/PTY EIO (#81521).
|
|
|
|
A stream-stall interrupt that corrupts the PTY used to leave the classic
|
|
CLI invalidating hundreds of times per second (escape-sequence flood).
|
|
Once EIO is observed, paints must stop.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import errno
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
|
|
def _make_cli_stub():
|
|
from cli import HermesCLI
|
|
|
|
cli = object.__new__(HermesCLI)
|
|
cli._terminal_io_broken = False
|
|
cli._resize_recovery_pending = False
|
|
cli._last_invalidate = 0.0
|
|
cli._pet_anim_running = False
|
|
cli._app = MagicMock()
|
|
return cli
|
|
|
|
|
|
class TestTerminalIoBrokenFreeze:
|
|
def test_mark_terminal_io_broken_is_idempotent(self):
|
|
cli = _make_cli_stub()
|
|
cli._mark_terminal_io_broken("first")
|
|
cli._mark_terminal_io_broken("second")
|
|
assert cli._terminal_io_broken is True
|
|
|
|
def test_invalidate_stops_after_eio(self):
|
|
cli = _make_cli_stub()
|
|
cli._app.invalidate.side_effect = OSError(errno.EIO, "Input/output error")
|
|
|
|
cli._invalidate(min_interval=0.0)
|
|
|
|
assert cli._terminal_io_broken is True
|
|
assert cli._app.invalidate.call_count == 1
|
|
|
|
cli._invalidate(min_interval=0.0)
|
|
# Frozen — no further paints.
|
|
assert cli._app.invalidate.call_count == 1
|
|
|
|
def test_force_full_redraw_skipped_when_broken(self):
|
|
cli = _make_cli_stub()
|
|
cli._terminal_io_broken = True
|
|
cli._force_full_redraw()
|
|
cli._app.invalidate.assert_not_called()
|
|
|
|
def test_recover_terminal_after_interrupt_skips_when_broken(self):
|
|
cli = _make_cli_stub()
|
|
cli._terminal_io_broken = True
|
|
cli._force_full_redraw = MagicMock()
|
|
cli._recover_terminal_after_interrupt()
|
|
cli._force_full_redraw.assert_not_called()
|