teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
51 lines
1.5 KiB
Python
51 lines
1.5 KiB
Python
"""Behavioral tests for the state-holder and repair-admission authority."""
|
|
|
|
import os
|
|
|
|
import pytest
|
|
|
|
import hermes_state_holders
|
|
|
|
|
|
@pytest.mark.linux_only
|
|
def test_foreign_holder_accepts_same_inode_reached_through_an_alias(
|
|
tmp_path, monkeypatch
|
|
):
|
|
"""Descriptor identity is authoritative even when /proc spells another path."""
|
|
db_path = tmp_path / "state.db"
|
|
db_path.touch()
|
|
alias_path = tmp_path / "namespace-alias" / "state.db"
|
|
|
|
proc_root = tmp_path / "proc"
|
|
for pid in (111, 222):
|
|
(proc_root / str(pid) / "fd").mkdir(parents=True)
|
|
os.symlink(db_path, proc_root / "222" / "fd" / "3")
|
|
|
|
monkeypatch.setattr(hermes_state_holders.os, "getpid", lambda: 111)
|
|
real_listdir = os.listdir
|
|
|
|
def _listdir(path):
|
|
if isinstance(path, str):
|
|
path = path.replace("/proc", str(proc_root))
|
|
return real_listdir(path)
|
|
|
|
monkeypatch.setattr(hermes_state_holders.os, "listdir", _listdir)
|
|
|
|
def _readlink(path):
|
|
if path == "/proc/222/fd/3":
|
|
return str(alias_path)
|
|
return os.readlink(path.replace("/proc", str(proc_root)))
|
|
|
|
monkeypatch.setattr(hermes_state_holders.os, "readlink", _readlink)
|
|
real_stat = os.stat
|
|
|
|
def _stat(path, *args, **kwargs):
|
|
path = str(path).replace("/proc", str(proc_root))
|
|
return real_stat(path, *args, **kwargs)
|
|
|
|
monkeypatch.setattr(hermes_state_holders.os, "stat", _stat)
|
|
|
|
assert hermes_state_holders.foreign_state_db_holders(db_path) == [
|
|
(222, str(alias_path))
|
|
]
|