teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
35 lines
1.4 KiB
Python
35 lines
1.4 KiB
Python
"""Regression tests for Windows desktop-update Unix timestamps.
|
|
|
|
PowerShell's ``Get-Date -UFormat %s`` is locale-sensitive. Under an ``es-ES``
|
|
culture it can produce a comma decimal separator, and parsing that string with
|
|
``InvariantCulture`` turns a ten-digit Unix timestamp plus fractional seconds
|
|
into a value too large for ``System.Int32``. The detached Windows updater must
|
|
use a locale-independent Unix timestamp API for both marker and result files.
|
|
|
|
The updater script is not executable on the Linux CI lane, so these tests lock
|
|
the source-level contract and reject the exact broken conversion.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent
|
|
WINDOWS_UPDATE_PS1 = REPO_ROOT / "scripts" / "desktop-update" / "windows.ps1"
|
|
|
|
|
|
def test_windows_update_uses_locale_independent_unix_seconds() -> None:
|
|
source = WINDOWS_UPDATE_PS1.read_text(encoding="utf-8")
|
|
safe_expression = "[DateTimeOffset]::UtcNow.ToUnixTimeSeconds()"
|
|
unsafe_expression = "[int][double]::Parse((Get-Date -UFormat %s)"
|
|
|
|
assert source.count(safe_expression) == 2, (
|
|
"windows.ps1 must use DateTimeOffset Unix seconds for both the "
|
|
"update marker and the finished result timestamp"
|
|
)
|
|
assert unsafe_expression not in source, (
|
|
"windows.ps1 must not parse locale-sensitive Get-Date -UFormat %s "
|
|
"output through System.Int32"
|
|
)
|