teknium1
d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
56 lines
2.3 KiB
Python
56 lines
2.3 KiB
Python
"""Regression: install.ps1 must stay pure ASCII.
|
|
|
|
Issues #66994 / #67000 reported the Windows GUI installer (Hermes-Setup.exe)
|
|
crashing before it did anything, with a cascade of PowerShell parser errors at
|
|
lines 1619 / 1770 ("Missing argument in parameter list", "A 'using' statement
|
|
must appear before any other statements in a script").
|
|
|
|
Root cause: ``scripts/install.ps1`` has no UTF-8 BOM, and a commit added two
|
|
non-ASCII characters *inside double-quoted string literals* (a bullet and an
|
|
em-dash). Windows PowerShell 5.1 -- which the bootstrap runs the cached script
|
|
under -- reads a BOM-less ``.ps1`` in the system ANSI code page (e.g. CP1252),
|
|
not UTF-8. The em-dash's UTF-8 tail byte (0x94) decodes to a "smart" close-quote
|
|
(U+201D), which the PowerShell tokenizer treats as a string delimiter. That
|
|
prematurely closes the string and desyncs the parser for the rest of the file,
|
|
surfacing as unrelated syntax errors far downstream.
|
|
|
|
Non-ASCII bytes inside ``#`` comments are harmless (the tokenizer skips a
|
|
comment to end-of-line regardless of what it contains), which is why the file
|
|
carried em-dashes in comments for months without breaking -- only a non-ASCII
|
|
byte in *code* (a string literal) triggers the desync.
|
|
|
|
This test is source-level because Linux CI cannot execute the PowerShell
|
|
installer. Keeping the whole file ASCII-only is the transport-independent
|
|
invariant: pure ASCII cannot be misdecoded under any code page, BOM or not, so
|
|
the bug class cannot recur -- in a comment or a string.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent
|
|
INSTALL_PS1 = REPO_ROOT / "scripts" / "install.ps1"
|
|
|
|
|
|
def test_install_ps1_is_pure_ascii() -> None:
|
|
raw = INSTALL_PS1.read_bytes()
|
|
|
|
offenders = []
|
|
line_no = 1
|
|
for byte in raw:
|
|
if byte == 0x0A:
|
|
line_no += 1
|
|
elif byte >= 0x80:
|
|
offenders.append(line_no)
|
|
|
|
assert not offenders, (
|
|
"scripts/install.ps1 must be pure ASCII so Windows PowerShell 5.1 "
|
|
"(which reads a BOM-less .ps1 in the system ANSI code page, not UTF-8) "
|
|
"cannot misdecode a byte into a stray quote and desync the parser "
|
|
"(issues #66994 / #67000). Non-ASCII bytes found on line(s): "
|
|
f"{sorted(set(offenders))}. Use ASCII equivalents (em-dash -> '--', "
|
|
"bullet -> '-')."
|
|
)
|