e31466bc5d
Drop tests/gateway/test_slack_conversational_senders.py (12 parametrized cases driving _handle_slack_message end-to-end for allow_bots policies and canvas mentions — the allow_bots matrix is already covered by the existing bot-filter tests in test_slack.py) and fold the remaining coverage into two _prefilter_inbound tests: every housekeeping subtype is dropped, and every conversational subtype (absent, file_share, thread_broadcast, me_message, document_mention, bot_message under allow_bots=all) still passes. Distinct ts per event: the prefilter dedups by (team, ts) before the subtype gate. Adds the contributor email mapping for the second author.
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.