kshitij
26f39f7b90
fix(credentials): prefer ~/.hermes/.env over stale os.environ on key rotation ( #55528 )
...
`_resolve_api_key_provider_secret` resolved API keys via `get_env_value`,
which returns the `os.environ` value first and only falls back to
`~/.hermes/.env`. After a user rotates a key in `.env`, a stale value still
exported in the parent shell (Codex CLI, test runner, login profile) shadows
the fresh key on every request, producing persistent 401s.
The credential-pool seeding path was already fixed to prefer `.env`
(#18254/#18755), but the live request-time resolution path was not — so the
pool re-seeded with the fresh key while `_resolve_api_key_provider_secret`
kept returning the stale shell export. This closes that remaining path.
- config: add `get_env_value_prefer_dotenv()` — checks `~/.hermes/.env`
first, then `os.environ`. Distinct from `get_env_value()` (unchanged,
os.environ-first) so only Hermes-managed credential resolution flips
precedence; the generic helper's many callers are unaffected.
- auth: `_resolve_api_key_provider_secret` resolves through the new helper.
- tests: regression coverage for both the pool-seeding path and the
auth resolution path (a rotated `.env` key must beat a stale shell export).
Closes #20591 .
Co-authored-by: 0xDevNinja <manmit0x@gmail.com >
2026-06-30 09:49:52 +00:00
..
2026-06-29 04:25:18 -07:00
2026-06-25 00:11:15 -07:00
2026-06-28 22:11:48 -05:00
2026-06-19 12:38:31 -07:00
2026-06-13 02:36:09 -07:00
2026-06-27 15:59:00 -07:00
2026-06-24 00:54:18 +05:30
2026-06-21 19:53:27 -07:00
2026-06-30 09:49:52 +00:00
2026-05-18 10:14:38 -07:00
2026-06-26 19:23:33 +05:30
2026-06-27 15:59:00 -07:00
2026-06-11 10:49:47 -07:00
2026-05-19 22:34:05 -07:00
2026-05-28 15:14:05 +10:00
2026-05-28 22:26:25 -07:00
2026-05-25 01:20:33 -07:00
2026-05-28 22:26:25 -07:00
2026-06-27 15:59:00 -07:00
2026-06-19 16:59:43 -07:00
2026-06-27 15:59:00 -07:00
2026-05-25 01:20:33 -07:00
2026-06-27 15:59:00 -07:00
2026-05-27 12:16:15 -07:00
2026-05-15 02:31:30 -07:00
2026-05-17 02:29:41 -07:00
2026-06-27 03:09:09 -07:00
2026-06-01 19:51:03 -07:00
2026-06-30 09:49:52 +00:00
2026-06-29 21:12:36 -07:00
2026-06-21 16:31:56 +05:30
2026-06-28 05:28:45 -07:00
2026-06-29 14:03:02 +10:00
2026-06-17 05:20:32 -07:00
2026-06-01 16:58:58 -07:00
2026-06-27 21:30:37 -07:00
2026-06-19 07:05:42 -07:00
2026-06-24 18:56:26 -07:00
2026-06-27 20:45:31 -07:00
2026-05-11 11:13:25 -07:00
2026-06-27 15:59:00 -07:00
2026-06-27 15:59:00 -07:00
2026-06-28 15:38:39 -07:00
2026-05-23 05:24:57 -07:00
2026-05-23 05:24:57 -07:00
2026-06-27 21:30:37 -07:00
2026-06-27 15:59:00 -07:00
2026-06-28 13:49:08 -07:00
2026-06-22 12:20:09 -07:00
2026-06-06 18:22:38 -07:00
2026-06-30 00:59:29 -05:00
2026-06-27 03:43:38 -07:00
2026-06-28 02:44:04 -07:00
2026-06-06 19:29:00 -07:00
2026-05-29 04:22:27 -07:00
2026-06-07 06:14:24 -07:00
2026-06-21 17:06:48 -07:00
2026-06-25 21:46:58 -07:00
2026-06-03 05:41:35 -07:00
2026-06-28 22:04:22 -05:00
2026-06-19 07:46:33 -07:00
2026-06-27 15:59:00 -07:00
2026-06-27 15:59:00 -07:00
2026-06-26 00:35:27 -07:00
2026-05-26 12:48:14 -07:00
2026-06-21 19:05:27 -07:00
2026-06-30 02:08:37 -07:00
2026-06-22 19:16:47 -05:00
2026-06-18 16:48:47 -05:00
2026-06-17 01:04:26 +08:00
2026-06-06 23:07:25 +05:30
2026-05-20 09:18:23 -07:00
2026-06-25 13:52:06 -07:00
2026-06-27 03:43:16 -07:00
2026-06-08 22:31:06 -07:00
2026-06-10 00:24:06 -07:00
2026-06-13 13:47:08 -07:00
2026-06-27 11:45:07 -07:00
2026-06-27 21:23:25 -07:00
2026-06-28 20:46:44 -07:00
2026-06-12 08:51:10 +00:00
2026-06-21 22:43:48 -07:00
2026-06-19 01:53:32 +05:30
2026-06-24 00:14:49 -07:00
2026-06-28 02:05:20 -07:00
2026-05-07 07:18:21 -07:00
2026-05-29 17:49:15 -07:00
2026-06-24 13:48:38 -05:00
2026-05-23 01:07:01 -04:00
2026-06-13 13:23:59 -07:00
2026-06-30 00:59:29 -05:00
2026-06-04 02:20:31 +05:30
2026-05-28 22:26:25 -07:00
2026-06-27 15:59:00 -07:00
2026-06-29 02:35:57 -07:00
2026-06-25 16:40:26 -05:00
2026-06-25 16:40:26 -05:00
2026-05-30 02:53:42 -07:00
2026-06-25 13:52:06 -07:00
2026-06-29 02:25:48 -07:00
2026-05-28 02:36:09 -07:00
2026-05-29 00:31:44 -07:00
2026-06-08 07:03:12 -07:00
2026-06-27 15:59:00 -07:00
2026-06-28 20:46:44 -07:00
2026-06-17 01:04:26 +08:00
2026-06-06 18:36:40 -07:00
2026-05-29 13:24:12 -07:00
2026-06-21 19:05:27 -07:00
2026-05-28 22:26:25 -07:00
2026-06-19 07:46:33 -07:00
2026-06-29 21:33:00 +10:00
2026-06-15 07:46:34 -07:00
2026-05-17 02:29:41 -07:00
2026-06-11 07:51:01 -07:00
2026-06-27 21:24:08 -07:00
2026-06-14 22:54:54 +05:30
2026-06-26 11:04:41 -07:00
2026-05-18 20:05:23 -07:00
2026-06-29 01:02:53 -07:00
2026-06-25 16:40:26 -05:00
2026-06-10 21:39:22 -04:00
2026-05-28 22:26:25 -07:00
2026-06-11 10:49:47 -07:00
2026-06-05 03:20:10 -07:00
2026-05-19 14:25:10 -07:00
2026-06-27 04:01:12 +05:30
2026-06-29 21:11:58 -07:00
2026-06-26 14:07:43 +05:30
2026-06-06 18:22:38 -07:00
2026-06-28 14:29:59 -05:00
2026-06-30 00:54:14 -05:00
2026-05-24 04:55:18 -07:00
2026-06-08 11:32:43 -07:00
2026-06-09 23:21:14 -07:00
2026-05-20 09:18:23 -07:00