fcd4778e1b
Slim the salvaged #112111 mechanism (issue #112109) while keeping its behaviour: the boot pass and the reconnect hook both run _replay_pending_planned_restart_notification, which sends to every home channel still owed an online notice, records delivered targets in .restart_pending.json and unlinks the marker only when every owed target (configured home with gateway_restart_notification=true) has been reached. Dropped from the contributor diff: - the per-target on_delivered checkpoint callback and pending_targets field: delivered targets are written once after the pass. Residual is a benign duplicate notice only if the process dies mid send-loop. - getattr-based lazy lock -> class attribute default, same idiom as run_profile_reconcile._reconcile_lock. - _clear_planned_restart_notification in gateway/run.py: no production caller remained; the roundtrip test unlinks the path directly. - tests trimmed to two invariants: offline-at-boot is replayed once on reconnect (with live-at-boot control), and partial delivery is persisted so a fresh process does not re-notify and an opted-out home never keeps the marker alive. Live probe (temp HERMES_HOME, Discord home, adapter absent at boot then reconnected): base consumed the marker with 0 sends; fixed head retains it and sends the online notice exactly once on reconnect, then clears it.
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.