slow4cyl
452861fdc1
review follow-up: violation-only retry streak with defined max_retries precedence
...
Address the hermes-sweeper review of #61233 : the bounded retry budget
is now a clean-exit-specific streak, not a share of the unified
consecutive_failures counter.
- detect_crashed_workers stamps a protocol_violation marker into the
violation run's metadata (via the event payload _end_run copies);
_protocol_violation_streak derives the streak from run history:
consecutive most-recent violation runs, rate_limited runs neutral
(mirroring their unified-counter treatment), any other closed run
resets it. Mixed failure kinds can neither consume nor extend the
budget.
- Below-budget violations no longer call _record_task_failure at all:
the task returns to ready with last_failure_error stamped directly
(including the corrective retry guidance wording adopted from #61817 ,
which build_worker_context surfaces to the retry worker) and the
unified counter is untouched, keeping the two budgets independent.
- At the bound the trip funnels through _record_task_failure with a new
keyword-only force_trip=True: the reaper has already resolved the
per-task max_retries override against the violation streak itself, so
the threshold comparison is skipped rather than double-applied.
max_retries keeps its documented top precedence in both directions:
max_retries=1 blocks on the first violation, max_retries=5 blocks on
the fifth consecutive one, unset uses the default bound of 3.
- Replace the first-violation-blocks regression test with five tests:
first occurrence retries (ready + guidance stamped + no gave_up +
unified counter untouched); streak trips exactly at the bound with
protocol_violations/protocol_violation_limit in the gave_up payload
and the auto-blocked side channel set; a prior nonzero crash does not
consume the violation budget; a non-violation failure between
violations resets the streak; max_retries precedence both directions.
All five fail against the previously reviewed diff and pass with this
follow-up. The test harness resolves hermes_cli.kanban_db fresh and
uses that single module object for the exit registry, liveness patch,
and reaper — earlier suite tests reload the module, and the old
mixed-object harness made _classify_worker_exit return unknown (the
reason the old test failed in full-suite runs on main).
Kanban suite: zero introduced failures vs upstream/main tip (62 vs 63
pre-existing environmental failures — the one no longer failing is the
old violation test this replaces; 662 passed vs 657).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com >
2026-07-14 16:47:33 +05:30
..
2026-05-27 02:12:27 -07:00
2026-06-08 22:54:25 -07:00
2026-06-28 05:49:21 -07:00
2026-05-28 22:26:25 -07:00
2026-05-25 01:20:33 -07:00
2026-07-01 02:18:56 -07:00
2026-06-09 14:45:19 -07:00
2026-07-14 02:59:39 +05:30
2026-06-15 05:36:20 +00:00
2026-05-27 00:43:32 -07:00
2026-07-11 03:51:43 -07:00
2026-06-01 09:57:10 -07:00
2026-06-23 23:28:21 -07:00
2026-06-17 05:48:35 -07:00
2026-06-13 05:15:26 -07:00
2026-07-02 13:17:41 -07:00
2026-07-02 13:17:41 -07:00
2026-07-10 17:50:43 +05:30
2026-06-04 16:54:40 -07:00
2026-07-07 15:12:54 -07:00
2026-05-28 22:26:25 -07:00
2026-05-08 14:27:40 -07:00
2026-05-24 04:25:32 -07:00
2026-07-02 13:17:41 -07:00
2026-07-12 02:59:14 -07:00
2026-05-18 20:01:34 -07:00
2026-07-11 12:28:55 +05:30
2026-05-28 22:26:25 -07:00
2026-06-26 19:23:33 +05:30
2026-05-28 15:14:05 +10:00
2026-05-15 14:45:43 -07:00
2026-07-06 11:17:41 -07:00
2026-05-28 22:26:25 -07:00
2026-06-27 11:45:07 -07:00
2026-05-28 22:26:25 -07:00
2026-06-19 01:53:32 +05:30
2026-06-19 01:53:32 +05:30
2026-06-19 01:53:32 +05:30
2026-05-28 15:14:05 +10:00
2026-05-28 22:26:25 -07:00
2026-06-27 15:59:00 -07:00
2026-05-28 22:26:25 -07:00
2026-06-08 15:12:12 -07:00
2026-05-25 01:20:33 -07:00
2026-06-12 13:42:42 -04:00
2026-06-23 18:42:05 -07:00
2026-05-28 22:26:25 -07:00
2026-07-10 00:47:51 +05:30
2026-06-10 00:24:06 -07:00
2026-05-28 22:26:25 -07:00
2026-07-01 23:51:54 +05:30
2026-07-12 00:26:49 -07:00
2026-05-13 09:34:15 -07:00
2026-07-09 18:23:18 -07:00
2026-05-28 22:26:25 -07:00
2026-07-09 18:23:18 -07:00
2026-07-12 03:05:12 -07:00
2026-07-03 20:18:00 +05:30
2026-06-29 21:12:36 -07:00
2026-06-21 16:31:56 +05:30
2026-07-05 00:44:15 -07:00
2026-05-29 23:45:05 -07:00
2026-06-30 03:27:41 -07:00
2026-07-09 14:30:16 +05:30
2026-06-23 23:39:22 -07:00
2026-06-11 05:01:25 +00:00
2026-07-06 02:21:32 -07:00
2026-06-21 22:43:55 -07:00
2026-05-28 22:26:25 -07:00
2026-05-09 18:43:40 -07:00
2026-05-07 05:27:47 -07:00
2026-05-07 05:27:47 -07:00
2026-07-06 12:26:21 -07:00
2026-06-07 18:21:03 -07:00
2026-06-07 18:21:03 -07:00
2026-06-01 16:58:58 -07:00
2026-06-01 16:58:58 -07:00
2026-07-11 12:28:55 +05:30
2026-06-13 05:51:05 -07:00
2026-07-05 00:55:51 -07:00
2026-07-02 04:51:56 +05:30
2026-07-08 08:10:55 -07:00
2026-06-29 04:25:18 -07:00
2026-05-27 02:12:27 -07:00
2026-05-28 22:26:25 -07:00
2026-06-26 19:15:18 -07:00
2026-06-29 04:25:18 -07:00
2026-07-09 12:21:16 +05:30
2026-05-27 02:12:27 -07:00
2026-07-06 03:18:02 -07:00
2026-05-27 02:12:27 -07:00
2026-06-26 19:15:18 -07:00
2026-05-27 02:12:27 -07:00
2026-07-03 20:18:00 +05:30
2026-06-02 23:43:27 -07:00
2026-06-04 03:03:35 -07:00
2026-07-09 12:21:16 +05:30
2026-05-12 13:59:22 -04:00
2026-06-09 13:56:33 +10:00
2026-06-27 10:08:13 +10:00
2026-06-06 12:43:28 -05:00
2026-06-15 15:33:15 +10:00
2026-07-09 14:48:50 +05:30
2026-07-01 00:38:17 -07:00
2026-07-09 16:13:59 -05:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-09 11:04:46 -07:00
2026-07-01 02:18:56 -07:00
2026-06-30 17:29:23 -07:00
2026-05-28 22:26:25 -07:00
2026-05-09 13:36:33 -07:00
2026-07-09 20:03:11 -07:00
2026-07-02 19:52:18 -05:00
2026-06-17 16:53:42 -07:00
2026-06-15 12:31:23 -07:00
2026-06-01 13:27:30 +10:00
2026-06-10 02:21:00 -07:00
2026-06-28 22:53:56 -07:00
2026-06-28 18:53:00 -07:00
2026-05-13 18:40:14 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-07-11 05:43:35 -07:00
2026-06-11 06:10:08 -07:00
2026-05-28 22:26:25 -07:00
2026-06-23 23:29:28 -07:00
2026-07-01 02:48:36 -07:00
2026-06-17 05:40:57 -07:00
2026-06-02 11:59:27 +10:00
2026-05-28 22:26:25 -07:00
2026-07-09 14:35:09 +05:30
2026-06-27 15:59:00 -07:00
2026-06-06 19:53:58 -07:00
2026-06-28 04:09:54 -07:00
2026-06-13 13:47:08 -07:00
2026-06-28 18:05:28 -05:00
2026-06-22 12:20:09 -07:00
2026-07-10 00:47:51 +05:30
2026-05-29 01:23:06 -07:00
2026-06-27 22:26:43 -07:00
2026-06-06 18:22:38 -07:00
2026-05-28 22:26:25 -07:00
2026-07-09 20:03:11 -07:00
2026-05-28 00:19:31 -07:00
2026-07-05 05:35:44 -07:00
2026-05-31 17:46:56 -05:00
2026-07-11 05:43:07 -07:00
2026-07-01 16:25:48 -05:00
2026-06-25 21:46:58 -07:00
2026-05-30 01:40:57 -07:00
2026-05-18 20:17:10 -07:00
2026-05-28 21:00:46 -07:00
2026-06-04 07:39:53 -07:00
2026-07-14 16:47:33 +05:30
2026-05-30 01:40:49 -07:00
2026-07-12 23:09:41 -07:00
2026-06-01 20:26:57 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 19:02:55 -07:00
2026-07-09 16:13:59 -05:00
2026-06-21 12:06:24 -07:00
2026-06-22 06:27:29 -07:00
2026-06-21 12:43:41 -07:00
2026-06-21 12:38:14 -07:00
2026-06-25 21:46:58 -07:00
2026-05-28 19:02:55 -07:00
2026-06-25 16:40:26 -05:00
2026-05-23 23:10:36 -07:00
2026-06-21 12:49:07 -07:00
2026-05-07 13:04:41 -07:00
2026-05-07 13:04:41 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 17:50:42 -07:00
2026-07-11 03:51:43 -07:00
2026-06-21 12:43:37 -07:00
2026-06-28 02:44:04 -07:00
2026-06-27 03:43:38 -07:00
2026-06-20 10:26:45 -07:00
2026-07-12 03:08:08 -07:00
2026-05-19 01:28:32 -07:00
2026-06-19 07:46:33 -07:00
2026-06-19 07:46:33 -07:00
2026-06-19 07:46:33 -07:00
2026-06-19 07:46:33 -07:00
2026-06-19 07:46:33 -07:00
2026-06-19 07:46:33 -07:00
2026-06-19 07:46:33 -07:00
2026-06-19 07:46:33 -07:00
2026-06-19 07:46:33 -07:00
2026-06-05 07:54:08 -05:00
2026-07-05 19:10:00 -07:00
2026-06-14 04:24:14 -07:00
2026-07-06 03:18:07 -07:00
2026-05-28 22:26:25 -07:00
2026-06-21 19:05:27 -07:00
2026-06-27 04:59:23 +05:30
2026-05-28 22:26:25 -07:00
2026-06-18 16:48:47 -05:00
2026-05-28 22:26:25 -07:00
2026-07-07 04:09:35 -07:00
2026-06-17 01:04:26 +08:00
2026-07-05 23:00:34 +05:30
2026-07-03 00:22:49 -07:00
2026-06-18 13:47:31 -07:00
2026-06-10 00:24:06 -07:00
2026-06-13 13:47:08 -07:00
2026-06-19 07:07:06 -07:00
2026-07-03 03:33:06 -07:00
2026-06-23 02:03:21 +05:30
2026-07-06 02:46:24 -07:00
2026-07-10 13:10:30 +05:30
2026-07-12 03:04:07 -07:00
2026-06-19 07:07:06 -07:00
2026-07-14 03:11:19 -07:00
2026-06-27 21:23:25 -07:00
2026-07-11 12:28:55 +05:30
2026-05-28 22:26:25 -07:00
2026-06-12 08:51:10 +00:00
2026-06-21 22:43:48 -07:00
2026-06-15 23:24:55 -05:00
2026-07-01 05:06:00 -07:00
2026-07-02 06:52:46 +00:00
2026-07-07 00:53:56 -07:00
2026-06-11 07:51:01 -07:00
2026-06-05 06:43:51 -07:00
2026-05-29 23:45:05 -07:00
2026-07-06 11:10:51 -07:00
2026-05-09 23:17:25 -07:00
2026-06-02 06:31:37 -07:00
2026-05-17 02:29:41 -07:00
2026-06-27 21:23:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-17 12:33:56 +05:30
2026-06-20 14:18:33 -05:00
2026-06-05 06:55:09 -07:00
2026-07-07 21:13:19 -07:00
2026-05-23 17:49:47 -07:00
2026-05-28 22:26:25 -07:00
2026-07-01 04:05:15 -07:00
2026-05-28 22:26:25 -07:00
2026-06-07 08:02:55 +00:00
2026-07-06 04:38:17 -07:00
2026-07-06 11:20:47 -07:00
2026-06-13 13:23:59 -07:00
2026-05-25 01:41:19 -07:00
2026-05-24 18:04:54 -07:00
2026-07-07 15:14:30 -07:00
2026-05-09 13:02:25 -07:00
2026-05-17 13:54:12 -07:00
2026-06-07 21:50:57 -07:00
2026-05-28 22:26:25 -07:00
2026-06-15 11:43:23 +10:00
2026-07-05 00:48:50 -07:00
2026-06-24 07:46:54 -07:00
2026-06-25 16:40:26 -05:00
2026-06-25 16:40:26 -05:00
2026-05-25 01:20:33 -07:00
2026-06-21 20:21:33 -07:00
2026-07-05 19:13:20 -07:00
2026-06-21 19:53:27 -07:00
2026-07-05 11:44:53 +05:30
2026-05-31 15:02:26 -07:00
2026-06-27 21:23:25 -07:00
2026-06-25 13:52:06 -07:00
2026-06-27 19:49:02 -07:00
2026-05-29 02:24:48 -07:00
2026-06-27 15:59:00 -07:00
2026-06-08 07:03:12 -07:00
2026-07-07 00:53:48 -07:00
2026-05-31 03:19:37 -07:00
2026-06-21 20:21:11 -07:00
2026-05-28 22:26:25 -07:00
2026-05-08 14:27:40 -07:00
2026-06-08 10:01:47 -07:00
2026-05-28 03:34:47 -07:00
2026-07-11 05:43:07 -07:00
2026-07-07 02:32:32 -07:00
2026-06-17 01:04:26 +08:00
2026-06-06 18:36:40 -07:00
2026-05-12 01:02:25 -07:00
2026-06-21 19:05:27 -07:00
2026-05-28 22:26:25 -07:00
2026-06-12 11:48:06 -07:00
2026-06-30 17:58:52 -05:00
2026-06-29 21:33:00 +10:00
2026-05-28 22:26:25 -07:00
2026-07-09 19:54:02 -07:00
2026-07-09 16:46:07 -07:00
2026-07-07 12:36:41 -07:00
2026-07-09 19:54:02 -07:00
2026-07-05 22:04:52 -07:00
2026-05-10 13:06:25 -07:00
2026-07-03 13:44:00 -07:00
2026-05-28 22:26:25 -07:00
2026-07-05 23:01:10 -07:00
2026-07-07 15:12:49 -07:00
2026-07-12 23:44:16 -07:00
2026-07-05 14:51:49 -07:00
2026-05-15 10:36:38 +05:30
2026-07-09 20:03:11 -07:00
2026-05-28 22:26:25 -07:00
2026-06-01 16:58:58 -07:00
2026-06-05 04:06:17 -07:00
2026-05-28 22:26:25 -07:00
2026-06-08 09:42:44 -07:00
2026-05-19 01:28:32 -07:00
2026-05-25 01:20:33 -07:00
2026-05-31 09:13:06 -07:00
2026-06-24 17:56:30 +05:30
2026-07-05 13:42:46 -07:00
2026-07-09 19:57:54 -07:00
2026-06-10 01:02:40 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-29 01:02:53 -07:00
2026-06-20 23:23:47 -07:00
2026-05-08 16:07:23 -07:00
2026-06-10 21:39:22 -04:00
2026-07-02 04:59:02 -07:00
2026-06-30 04:38:43 -07:00
2026-06-17 12:55:40 +05:30
2026-06-07 22:56:23 -07:00
2026-06-18 12:01:54 +10:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-06-11 19:06:29 -04:00
2026-06-07 21:50:57 -07:00
2026-05-08 11:18:14 -07:00
2026-06-14 03:08:52 -07:00
2026-07-08 07:09:08 -07:00
2026-06-10 00:24:06 -07:00
2026-05-25 01:47:55 -07:00
2026-06-21 22:44:25 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-07-07 16:27:28 -07:00
2026-06-26 14:07:43 +05:30
2026-05-24 18:04:54 -07:00
2026-05-28 22:26:25 -07:00
2026-06-03 16:40:28 -07:00
2026-05-27 22:03:45 -05:00
2026-06-21 13:10:22 -07:00
2026-07-07 21:13:19 -07:00
2026-07-07 05:12:24 -07:00
2026-06-04 02:31:49 -07:00
2026-06-15 06:18:27 -07:00
2026-06-25 21:39:29 -06:00
2026-06-22 06:02:31 -07:00
2026-06-19 19:58:26 -07:00
2026-06-27 11:43:01 -07:00
2026-06-28 02:40:37 -07:00
2026-06-18 12:42:58 +05:30
2026-07-05 19:35:30 -07:00
2026-06-03 04:59:49 -07:00
2026-07-03 04:08:37 -07:00
2026-05-08 14:55:40 -07:00
2026-06-21 13:10:22 -07:00
2026-05-28 22:26:25 -07:00
2026-07-11 12:28:55 +05:30
2026-07-03 04:23:15 +05:30
2026-06-04 23:20:29 -04:00
2026-06-28 17:02:05 -05:00
2026-06-06 12:50:58 -05:00
2026-07-01 05:25:33 -07:00
2026-05-15 12:11:32 -07:00
2026-07-09 12:21:16 +05:30
2026-06-21 12:29:18 -07:00
2026-07-03 20:18:00 +05:30
2026-07-10 11:43:09 +05:30
2026-07-04 17:58:05 +05:30
2026-06-11 09:41:35 -07:00
2026-07-08 00:20:13 +00:00
2026-06-28 16:29:52 -05:00
2026-05-24 15:00:44 -07:00
2026-06-17 05:40:57 -07:00
2026-07-07 13:54:07 -07:00
2026-07-09 01:19:07 +05:30
2026-06-08 11:32:43 -07:00
2026-06-28 03:58:18 -07:00
2026-06-04 07:49:34 -07:00
2026-06-11 06:10:27 -07:00
2026-07-03 15:22:43 -05:00
2026-07-13 21:01:55 -07:00
2026-06-11 11:49:08 -07:00
2026-07-08 08:10:55 -07:00
2026-05-23 01:07:01 -04:00
2026-07-07 17:45:51 -07:00
2026-05-28 22:26:25 -07:00
2026-06-08 11:32:43 -07:00
2026-06-07 18:28:23 -07:00
2026-06-17 09:49:46 -07:00
2026-07-02 13:17:41 -07:00
2026-06-15 17:03:35 +05:30
2026-07-02 13:17:41 -07:00
2026-06-15 17:08:19 +05:30
2026-05-24 18:12:16 -07:00
2026-05-28 22:26:25 -07:00
2026-05-28 22:26:25 -07:00
2026-07-09 16:58:37 -07:00