brooklyn!
64646dda56
* feat(agent): read_preview — the desktop-gated tool that reads the in-app browser The agent could open the preview pane (open_preview) and read the embedded terminal (read_terminal), but the browser it had just opened was a black box — 'what does this page say?' had no answer. read_preview mirrors read_terminal end to end: HERMES_DESKTOP-gated via check_fn (zero schema footprint outside the GUI), dispatched through the same agent callback pattern, windowed with start/count so a long page pages instead of flooding context. * feat(gateway): preview.read blocking bridge Same lifecycle as terminal.read: the tool blocks on preview.read.request, the renderer answers preview.read.respond (allow_expired — a slow page extraction losing the 45s race must not surface a raw 4009), and a timeout emits preview.read.expire so late answers resolve quietly. * feat(desktop): the renderer serializes the active preview tab for the agent preview-reader.ts is the preview analog of the terminal's buffer registry: the URL pane registers a page reader (webview executeJavaScript → title + visible innerText) keyed by tab id; readActivePreview resolves the ACTIVE tab, windows the text (24k cap per read), and answers file/artifact tabs with identity plus a note pointing at the tool that reads that content directly. The gateway event handler answers preview.read.request beside terminal.read.request.
64 lines
2.0 KiB
Python
64 lines
2.0 KiB
Python
"""Tests for the desktop-gated ``read_preview`` tool."""
|
|
|
|
import json
|
|
|
|
from tools import read_preview_tool as rp
|
|
|
|
|
|
def test_gated_on_desktop(monkeypatch):
|
|
"""Hidden unless HERMES_DESKTOP is set (mirrors read_terminal)."""
|
|
monkeypatch.delenv("HERMES_DESKTOP", raising=False)
|
|
assert rp.check_read_preview_requirements() is False
|
|
|
|
monkeypatch.setenv("HERMES_DESKTOP", "1")
|
|
assert rp.check_read_preview_requirements() is True
|
|
|
|
|
|
def test_requires_callback():
|
|
"""Outside the desktop GUI there is no bridge — a clear error, no crash."""
|
|
result = json.loads(rp.read_preview_tool(callback=None))
|
|
assert "desktop" in result["error"]
|
|
|
|
|
|
def test_empty_answer_means_nothing_open():
|
|
result = json.loads(rp.read_preview_tool(callback=lambda **_: ""))
|
|
assert "error" in result
|
|
|
|
|
|
def test_passes_json_through():
|
|
payload = {"kind": "url", "url": "https://news.ycombinator.com", "title": "HN", "text": "hello"}
|
|
result = json.loads(rp.read_preview_tool(callback=lambda **_: json.dumps(payload)))
|
|
assert result == payload
|
|
|
|
|
|
def test_wraps_non_json_text():
|
|
result = json.loads(rp.read_preview_tool(callback=lambda **_: "plain words"))
|
|
assert result == {"text": "plain words"}
|
|
|
|
|
|
def test_window_forwarded_and_validated():
|
|
seen = {}
|
|
|
|
def cb(**kwargs):
|
|
seen.update(kwargs)
|
|
return json.dumps({"kind": "url"})
|
|
|
|
rp.read_preview_tool(start=100, count=500, callback=cb)
|
|
assert seen == {"start": 100, "count": 500}
|
|
|
|
# Floors mirror read_terminal: start >= 0, count >= 1.
|
|
seen.clear()
|
|
rp.read_preview_tool(start=-5, count=0, callback=cb)
|
|
assert seen == {"start": 0, "count": 1}
|
|
|
|
result = json.loads(rp.read_preview_tool(start="lots", callback=cb))
|
|
assert "integers" in result["error"]
|
|
|
|
|
|
def test_callback_failure_is_reported():
|
|
def _boom(**_kwargs):
|
|
raise RuntimeError("renderer went away")
|
|
|
|
result = json.loads(rp.read_preview_tool(callback=_boom))
|
|
assert "renderer went away" in result["error"]
|