Xi Zhang
92df3e1844
* feat(cli): migrate command handling to CommandManager and enhance UI interactions * feat(cli): add /clear and /help commands to enhance user experience * feat(cli): implement /new and /resume commands with interactive session management * Refactor MCP and Skills Command Handling - Moved the interactive picker style to a centralized widget for consistency across MCP and Skills commands. - Updated the MCP command to remove the old command dispatch logic, delegating to the new InstallMCPCommand. - Enhanced the Skills command to utilize a new interactive picker for skill selection, improving user experience. - Implemented cancellation handling in the picker to differentiate between user cancellations and empty selections. - Added comprehensive tests for the new command structures and picker functionalities to ensure reliability. * refactor(cli): streamline CommandManager dispatch and remove deprecated command set * refactor(cli): enhance error handling and state management in ChannelCommand and RichCLICommandUI * refactor(cli): update lifecycle callback terminology and improve async prompt handling in RichCLICommandUI * refactor(cli): enhance SlashCommandCompleter to dynamically fetch workspace directory for autocompletion * refactor(cli): unify quit handling in RichCLICommandUI with shared _stop helper * refactor(cli): remove hardcoded slash commands and utilize command manager for dynamic completion * refactor(cli): update MCP and skills command files for improved clarity and organization * refactor(mcp_ui): remove unnecessary newline in _show_mcp_config function
105 lines
3.5 KiB
Python
105 lines
3.5 KiB
Python
"""Tests for the /evoskills command (InstallSkills)."""
|
|
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
from tests.conftest import run_async as _run
|
|
|
|
|
|
def _ctx(supports_interactive=True):
|
|
from EvoScientist.commands.base import CommandContext
|
|
|
|
ui = MagicMock()
|
|
ui.supports_interactive = supports_interactive
|
|
ui.wait_for_skill_browse = AsyncMock()
|
|
return CommandContext(agent=None, thread_id="tid", ui=ui), ui
|
|
|
|
|
|
_INDEX = [
|
|
{
|
|
"name": "paper-writing",
|
|
"description": "author papers",
|
|
"install_source": "repo@paper-writing",
|
|
"tags": ["writing"],
|
|
},
|
|
{
|
|
"name": "research-ideation",
|
|
"description": "brainstorm ideas",
|
|
"install_source": "repo@research-ideation",
|
|
"tags": ["core"],
|
|
},
|
|
]
|
|
|
|
|
|
class TestInstallSkills:
|
|
def test_picker_cancel_no_install(self):
|
|
from EvoScientist.commands.implementation.skills import InstallSkills
|
|
|
|
ctx, ui = _ctx()
|
|
ui.wait_for_skill_browse.return_value = None # cancelled
|
|
with (
|
|
patch(
|
|
"EvoScientist.tools.skills_manager.fetch_remote_skill_index",
|
|
return_value=_INDEX,
|
|
),
|
|
patch(
|
|
"EvoScientist.tools.skills_manager.install_skill",
|
|
) as install_mock,
|
|
):
|
|
_run(InstallSkills().execute(ctx, []))
|
|
install_mock.assert_not_called()
|
|
msgs = [c.args[0] for c in ui.append_system.call_args_list]
|
|
assert any("Browse cancelled" in m for m in msgs)
|
|
|
|
def test_picker_returns_selections_installs_each(self):
|
|
from EvoScientist.commands.implementation.skills import InstallSkills
|
|
|
|
ctx, ui = _ctx()
|
|
ui.wait_for_skill_browse.return_value = [
|
|
"repo@paper-writing",
|
|
"repo@research-ideation",
|
|
]
|
|
with (
|
|
patch(
|
|
"EvoScientist.tools.skills_manager.fetch_remote_skill_index",
|
|
return_value=_INDEX,
|
|
),
|
|
patch(
|
|
"EvoScientist.tools.skills_manager.install_skill",
|
|
return_value={"success": True, "name": "x"},
|
|
) as install_mock,
|
|
):
|
|
_run(InstallSkills().execute(ctx, []))
|
|
assert install_mock.call_count == 2
|
|
|
|
def test_channel_auto_install_on_tag(self):
|
|
"""Non-interactive UI + tag arg → auto-installs matching skills."""
|
|
from EvoScientist.commands.implementation.skills import InstallSkills
|
|
|
|
ctx, ui = _ctx(supports_interactive=False)
|
|
with (
|
|
patch(
|
|
"EvoScientist.tools.skills_manager.fetch_remote_skill_index",
|
|
return_value=_INDEX,
|
|
),
|
|
patch(
|
|
"EvoScientist.tools.skills_manager.install_skill",
|
|
return_value={"success": True, "name": "x"},
|
|
) as install_mock,
|
|
):
|
|
_run(InstallSkills().execute(ctx, ["core"]))
|
|
# "core" matches research-ideation only → 1 install, no picker call
|
|
assert install_mock.call_count == 1
|
|
ui.wait_for_skill_browse.assert_not_called()
|
|
|
|
def test_fetch_failure_prints_error(self):
|
|
from EvoScientist.commands.implementation.skills import InstallSkills
|
|
|
|
ctx, ui = _ctx()
|
|
with patch(
|
|
"EvoScientist.tools.skills_manager.fetch_remote_skill_index",
|
|
side_effect=RuntimeError("network fail"),
|
|
):
|
|
_run(InstallSkills().execute(ctx, []))
|
|
msgs = [c.args[0] for c in ui.append_system.call_args_list]
|
|
assert any("Failed to fetch" in m for m in msgs)
|