ouyangbo/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 9 Packages Projects Releases Wiki Activity

refactor(credential_files): prune excluded dirs before descending in the sync walk

Browse Source 
Replaces the three hand-copied rglob loops + post-hoc parts check with one
os.walk generator that drops EXCLUDED_SKILL_DIRS from dirnames before
recursing. Same file set as the cherry-picked fix (the test binds it), but
the walk no longer stats every file under .hub/.curator_backups/node_modules
on each 5s FileSyncManager tick.

Bench (synthetic skills tree: 20 skills + 400 .hub files + 5x8MB curator
tarballs + 50 archived files): iter_skills_files() 35ms -> 2.4ms.
This commit is contained in:
kshitijk4poor
2026-09-03 00:56:00 +05:30
committed by kshitij
parent edac49e473
commit 1d06ef3a5d
1 changed files with 19 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/credential_files.py
+19 -26
View File
@@ -346,21 +346,29 @@ def _safe_skills_path(skills_dir: Path) -> str:
return str(safe_dir)
def _is_excluded_skills_dir(rel: Path) -> bool:
"""True if *rel* sits under a directory excluded from skill scanning.
def _iter_syncable_files(root: Path):
"""Yield ``(path, rel)`` for every regular, non-symlink file under *root*
that a sandbox should receive.
Reuses ``agent.skill_utils.EXCLUDED_SKILL_DIRS`` so the sync path agrees
with discovery. These are local bookkeeping and dependency directories
(``.hub`` download cache, ``.archive``, ``.curator_backups``,
``node_modules``, ``__pycache__``, ``.git``, ...) that the remote agent
never reads.
Prunes ``agent.skill_utils.EXCLUDED_SKILL_DIRS`` *before* descending, so
the walk never enters local bookkeeping and dependency trees (``.hub``
download cache, ``.archive``, ``.curator_backups``, ``node_modules``,
``__pycache__``, ``.git``, ...) that the remote agent never reads — the
sync path agrees with discovery on what counts as skill content.
This deliberately does not use ``is_excluded_skill_path()``, which also
prunes ``references/``, ``templates/``, ``assets/`` and ``scripts/``.
Those hold progressive-disclosure support files and bundled scripts the
sandbox does execute, so they must keep syncing.
"""
return any(part in EXCLUDED_SKILL_DIRS for part in rel.parts[:-1])
for dirpath, dirnames, filenames in os.walk(root):
dirnames[:] = sorted(d for d in dirnames if d not in EXCLUDED_SKILL_DIRS)
base = Path(dirpath)
for name in filenames:
item = base / name
if item.is_symlink() or not item.is_file():
continue
yield item, item.relative_to(root)
def iter_skills_files(
@@ -379,12 +387,7 @@ def iter_skills_files(
skills_dir = hermes_home / "skills"
if skills_dir.is_dir():
container_root = f"{container_base.rstrip('/')}/skills"
for item in skills_dir.rglob("*"):
if item.is_symlink() or not item.is_file():
continue
rel = item.relative_to(skills_dir)
if _is_excluded_skills_dir(rel):
continue
for item, rel in _iter_syncable_files(skills_dir):
result.append({
"host_path": str(item),
"container_path": f"{container_root}/{rel}",
@@ -397,12 +400,7 @@ def iter_skills_files(
if not ext_dir.is_dir():
continue
container_root = f"{container_base.rstrip('/')}/external_skills/{idx}"
for item in ext_dir.rglob("*"):
if item.is_symlink() or not item.is_file():
continue
rel = item.relative_to(ext_dir)
if _is_excluded_skills_dir(rel):
continue
for item, rel in _iter_syncable_files(ext_dir):
result.append({
"host_path": str(item),
"container_path": f"{container_root}/{rel}",
@@ -411,12 +409,7 @@ def iter_skills_files(
if not proj_dir.is_dir():
continue
container_root = f"{container_base.rstrip('/')}/project_skills/{idx}"
for item in proj_dir.rglob("*"):
if item.is_symlink() or not item.is_file():
continue
rel = item.relative_to(proj_dir)
if _is_excluded_skills_dir(rel):
continue
for item, rel in _iter_syncable_files(proj_dir):
result.append({
"host_path": str(item),
"container_path": f"{container_root}/{rel}",