fix: clamp invalid effective_timeout to the 120s wait default instead of unbounded (review follow-up for #94305)

2026-08-31 08:25:24 -07:00
parent 97f2a571b5
commit 53e3c14f1d
1 changed files with 4 additions and 1 deletions
@@ -1556,7 +1556,10 @@ class BaseEnvironment(ABC):
        try:
            bound_s = float(effective_timeout) + _EXECUTE_WAIT_BOUND_GRACE_S
        except (TypeError, ValueError):
-            bound_s = None
+            # Defensive: a non-numeric timeout must not silently disable the
+            # backstop (that would recreate the unbounded wait this bound
+            # exists to prevent). Fall back to the module's 120s wait default.
+            bound_s = 120.0 + _EXECUTE_WAIT_BOUND_GRACE_S

        try:
            bounded = run_bounded_sync(