test: keep core review checks independent of optional ACP

2026-09-07 03:46:46 -07:00
parent 92f4246aa2
commit 5f88f0e9c3
1 changed files with 7 additions and 2 deletions
@@ -106,14 +106,19 @@ def test_review_tools_are_gated_and_visible_to_kanban_workers(
    assert "kanban_request_review" in names
    assert "kanban_request_changes" in names

-    from acp_adapter.tools import _POLISHED_TOOLS
    from agent.transports.hermes_tools_mcp_server import EXPOSED_TOOLS

-    assert "kanban_request_changes" in _POLISHED_TOOLS
    assert "kanban_request_changes" in EXPOSED_TOOLS
    assert "kanban_request_changes" in resolve_toolset("kanban")


+def test_review_changes_are_exposed_in_acp() -> None:
+    pytest.importorskip("acp", reason="ACP adapter requires the optional acp extra")
+    from acp_adapter.tools import _POLISHED_TOOLS
+
+    assert "kanban_request_changes" in _POLISHED_TOOLS
+
+
 def test_review_cli_round_trip_preserves_handoff(
    monkeypatch: pytest.MonkeyPatch,
    tmp_path: Path,