fix(codex): drop assistant images from Responses replay

Fixes #96816
This commit is contained in:
lEWFkRAD
2026-08-27 22:35:15 -04:00
committed by Teknium
parent b3f4f50771
commit 8de45940fb
2 changed files with 37 additions and 0 deletions
+11
View File
@@ -165,6 +165,13 @@ def _chat_content_to_responses_parts(content: Any, *, role: str = "user") -> Lis
``output_text`` inside user messages, so callers MUST pass the correct
role for the message being converted.
Image parts are likewise role-restricted: the API only accepts
``input_image`` on user-role messages. An assistant message carrying
``input_image`` is rejected with HTTP 400 on every history replay, which
permanently bricks the session (#96816), so image parts are dropped for
the assistant role here (the API cannot carry them in any form, so the
drop is lossless w.r.t. what would survive the wire).
Returns an empty list when ``content`` is not a list or contains no
recognized parts — callers fall back to the string path.
"""
@@ -186,6 +193,10 @@ def _chat_content_to_responses_parts(content: Any, *, role: str = "user") -> Lis
converted.append({"type": text_type, "text": text})
continue
if ptype in {"image_url", "input_image"}:
if role == "assistant":
# Responses API rejects input_image on assistant messages
# (HTTP 400 on every replay) — drop, see docstring (#96816).
continue
image_ref = part.get("image_url")
detail = part.get("detail")
if isinstance(image_ref, dict):
@@ -3,6 +3,7 @@ from types import SimpleNamespace
import pytest
from agent.codex_responses_adapter import (
_chat_content_to_responses_parts,
_chat_messages_to_responses_input,
_sanitize_replayed_fn_name,
_format_responses_error,
@@ -20,6 +21,31 @@ _HARMONY_SOURCE_SNIPPET = (
)
def test_chat_content_drops_images_from_assistant_role():
content = [
{"type": "text", "text": "generated image"},
{"type": "image_url", "image_url": {"url": "https://example.invalid/p.png"}},
{"type": "input_image", "image_url": "data:image/png;base64,AAAA"},
]
assert _chat_content_to_responses_parts(content, role="assistant") == [
{"type": "output_text", "text": "generated image"},
]
def test_chat_content_keeps_images_on_user_role():
content = [{
"type": "image_url",
"image_url": {"url": "https://example.invalid/p.png", "detail": "high"},
}]
assert _chat_content_to_responses_parts(content, role="user") == [{
"type": "input_image",
"image_url": "https://example.invalid/p.png",
"detail": "high",
}]
def _harmony_token(name: str) -> str:
"""Build a literal Harmony token without spelling it contiguously here."""
return f"<\x7c{name}\x7c>"