test(cron): trim kind-flip repeat tests to the two invariants

Keep the two tests that fail without the fix (one-shot -> recurring drops the
implicit times=1, recurring -> one-shot gains it) and fold the explicit-repeat
case into the first; drop the same-kind and explicit-finite cases, which only
pin behaviour the fix never touches.
This commit is contained in:
Teknium
2026-09-09 04:44:22 -07:00
parent 111aea1a01
commit ae65399d8f
+4 -28
View File
@@ -444,6 +444,7 @@ class TestJobCRUD:
create_job derives repeat from the schedule kind; update_job must honour
the same contract when the kind flips, otherwise a job "fixed" from a
one-shot to `every 15m` keeps times=1 and retires after its first fire.
An explicit repeat in the same update still wins over the re-derived default.
"""
from cron.jobs import update_job
@@ -454,6 +455,9 @@ class TestJobCRUD:
assert updated["schedule"]["kind"] == "interval"
assert updated["repeat"]["times"] is None
explicit = create_job(prompt="poll", schedule="in 15m")
assert update_job(explicit["id"], {"schedule": "every 15m", "repeat": 3})["repeat"]["times"] == 3
def test_recurring_turned_oneshot_becomes_once(self, tmp_cron_dir):
"""The reverse flip must gain the one-shot default instead of staying forever."""
from cron.jobs import update_job
@@ -465,34 +469,6 @@ class TestJobCRUD:
assert updated["schedule"]["kind"] == "once"
assert updated["repeat"]["times"] == 1
def test_explicit_repeat_in_same_update_wins(self, tmp_cron_dir):
"""An explicit repeat beats the re-derived default on kind flips."""
from cron.jobs import update_job
job = create_job(prompt="poll", schedule="in 15m")
updated = update_job(job["id"], {"schedule": "every 15m", "repeat": 3})
assert updated["repeat"]["times"] == 3
def test_same_kind_schedule_edit_keeps_repeat(self, tmp_cron_dir):
"""Re-pointing a recurring schedule at another cadence is not a kind flip."""
from cron.jobs import update_job
job = create_job(prompt="poll", schedule="every 15m", repeat=5)
updated = update_job(job["id"], {"schedule": "every 30m"})
assert updated["schedule"]["kind"] == "interval"
assert updated["repeat"]["times"] == 5
def test_explicit_finite_oneshot_keeps_budget_turned_recurring(self, tmp_cron_dir):
"""An explicitly finite one-shot (repeat=2) carries its budget to the recurring side."""
from cron.jobs import update_job
job = create_job(prompt="poll", schedule="in 15m", repeat=2)
updated = update_job(job["id"], {"schedule": "every 15m"})
assert updated["repeat"]["times"] == 2
def test_rejects_stale_past_one_shot_at_creation(self, tmp_cron_dir, monkeypatch):
now = datetime(2026, 3, 18, 4, 30, 0, tzinfo=timezone.utc)
monkeypatch.setattr("cron.jobs._hermes_now", lambda: now)