perf(desktop): skip store update when pet metadata is unchanged
mergePetInfoMeta now returns the same object reference when all fields match, and callers skip setPetInfo on reference equality. Without this, every 15s poll and window-focus refetch fired a nanostores set with a new-allocated object, triggering a React re-render of FloatingPet even when nothing changed — a regression from the old samePetRevision guard which returned without calling setPetInfo.
This commit is contained in:
@@ -171,7 +171,10 @@ export function FloatingPet() {
|
||||
const current = $petInfo.get()
|
||||
|
||||
if (hasPetSpriteForMeta(current, meta)) {
|
||||
setPetInfo(mergePetInfoMeta(current, meta))
|
||||
const merged = mergePetInfoMeta(current, meta)
|
||||
if (merged !== current) {
|
||||
setPetInfo(merged)
|
||||
}
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
import { $petInfo, setPetInfo } from './pet'
|
||||
import { $petGallery, adoptPet, loadPetGallery, resetPetGallery, type GatewayRequest } from './pet-gallery'
|
||||
import { $petGallery, adoptPet, loadPetGallery, type GatewayRequest, resetPetGallery } from './pet-gallery'
|
||||
|
||||
function localGallery() {
|
||||
return {
|
||||
|
||||
@@ -215,7 +215,10 @@ async function syncInfo(request: GatewayRequest): Promise<void> {
|
||||
const current = $petInfo.get()
|
||||
|
||||
if (hasPetSpriteForMeta(current, meta)) {
|
||||
setPetInfo(mergePetInfoMeta(current, meta))
|
||||
const merged = mergePetInfoMeta(current, meta)
|
||||
if (merged !== current) {
|
||||
setPetInfo(merged)
|
||||
}
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
@@ -9,6 +9,7 @@ import {
|
||||
flashPetActivity,
|
||||
hasPetSpriteForMeta,
|
||||
mergePetInfoMeta,
|
||||
type PetInfo,
|
||||
setPetActivity
|
||||
} from './pet'
|
||||
|
||||
@@ -105,6 +106,26 @@ describe('pet info metadata cache helpers', () => {
|
||||
spritesheetRevision: '100:2048'
|
||||
})
|
||||
})
|
||||
|
||||
it('returns the same reference when nothing changed to avoid redundant store updates', () => {
|
||||
const current: PetInfo = {
|
||||
enabled: true,
|
||||
slug: 'boba',
|
||||
displayName: 'Boba',
|
||||
scale: 0.33,
|
||||
spritesheetBase64: 'large-sprite-payload',
|
||||
spritesheetRevision: '100:2048'
|
||||
}
|
||||
const meta = {
|
||||
enabled: true,
|
||||
slug: 'boba',
|
||||
displayName: 'Boba',
|
||||
scale: 0.33,
|
||||
spritesheetRevision: '100:2048'
|
||||
}
|
||||
|
||||
expect(mergePetInfoMeta(current, meta)).toBe(current)
|
||||
})
|
||||
})
|
||||
|
||||
describe('flashPetActivity', () => {
|
||||
|
||||
@@ -60,7 +60,20 @@ export function hasPetSpriteForMeta(info: PetInfo, meta: PetInfoMeta): boolean {
|
||||
|
||||
export function mergePetInfoMeta(info: PetInfo, meta: PetInfoMeta): PetInfo {
|
||||
if (!meta.enabled) {
|
||||
return { enabled: false }
|
||||
return info.enabled ? { enabled: false } : info
|
||||
}
|
||||
|
||||
// Fast-path: nothing changed — return the same reference so callers can
|
||||
// skip the store update (nanostores fires on .set() regardless of deep
|
||||
// equality; returning `info` avoids a redundant re-render on every poll).
|
||||
if (
|
||||
info.enabled &&
|
||||
info.slug === meta.slug &&
|
||||
info.displayName === meta.displayName &&
|
||||
info.scale === meta.scale &&
|
||||
info.spritesheetRevision === meta.spritesheetRevision
|
||||
) {
|
||||
return info
|
||||
}
|
||||
|
||||
return {
|
||||
|
||||
Reference in New Issue
Block a user