ouyangbo/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 12 Packages Projects Releases Wiki Activity

test(agent): assert owner-scoped teardown instead of bulk cleanup

Browse Source
This commit is contained in:
Teknium
2026-09-07 02:45:40 -07:00
parent dca7a90cf8
commit cfe07df09f
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/tools/test_zombie_process_cleanup.py
+11 -4
View File
@@ -103,6 +103,7 @@ class TestAgentCloseMethod:
from run_agent import AIAgent
agent = AIAgent.__new__(AIAgent)
agent.session_id = "test-close-cleanup"
agent._process_owner_task_ids = {"sa-owned"}
agent._active_children = []
agent._active_children_lock = threading.Lock()
agent.client = None
@@ -111,11 +112,17 @@ class TestAgentCloseMethod:
patch("run_agent.cleanup_vm") as mock_cleanup_vm, \
patch("run_agent.cleanup_browser") as mock_cleanup_browser, \
patch("tools.computer_use.tool.release_computer_use_session") as mock_cleanup_cua:
mock_registry.list_sessions.return_value = [
{"session_id": "owned", "owner_task_id": "sa-owned", "status": "running"},
{"session_id": "foreign", "owner_task_id": "parent", "status": "running"},
{"session_id": "finished", "owner_task_id": "sa-owned", "status": "exited"},
]
agent.close()
mock_registry.kill_all.assert_called_once_with(
task_id="test-close-cleanup"
mock_registry.kill_process.assert_called_once_with(
"owned", source="agent_close", consume_output=True,
)
mock_registry.kill_all.assert_not_called()
mock_cleanup_vm.assert_called_once_with("test-close-cleanup")
mock_cleanup_browser.assert_called_once_with("test-close-cleanup")
mock_cleanup_cua.assert_called_once_with("test-close-cleanup")
@@ -149,7 +156,7 @@ class TestAgentCloseMethod:
agent.client = None
with patch(
"tools.process_registry.process_registry.kill_all",
"tools.process_registry.process_registry.list_sessions",
side_effect=RuntimeError("process cleanup failed"),
), patch(
"tools.computer_use.tool.release_computer_use_session",
@@ -272,7 +279,7 @@ class TestAgentCloseMethod:
) as mock_vm, patch(
"run_agent.cleanup_browser"
) as mock_browser:
mock_reg.kill_all.side_effect = RuntimeError("boom")
mock_reg.list_sessions.side_effect = RuntimeError("boom")
agent.close()