周鹤0668001310
92a8398087
Previously, setting HERMES_MANAGED=false (or 0, no, off) would be interpreted as a literal managed-system name, causing is_managed() to incorrectly return True and block update/config commands. - Add _MANAGED_FALSE_VALUES tuple for canonical false strings - Check false values before true values in get_managed_system() - Add parametrized regression tests for all false variants Fixes #12864
43 lines
1.7 KiB
Python
43 lines
1.7 KiB
Python
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.config import get_managed_system, is_managed, recommended_update_command
|
|
from hermes_cli.main import cmd_update
|
|
from tools.skills_hub_official import OptionalSkillSource
|
|
|
|
|
|
def test_recommended_update_command_defaults_to_hermes_update(monkeypatch):
|
|
monkeypatch.delenv("HERMES_MANAGED", raising=False)
|
|
|
|
# Also short-circuit the .managed marker path — CI runners may have an
|
|
# ambient ~/.hermes/.managed if a prior test left HERMES_HOME pointing
|
|
# somewhere with that marker, which would make get_managed_update_command()
|
|
# return "Update your Nix flake input ..." instead of falling through to
|
|
# detect_install_method().
|
|
with patch("hermes_cli.config.get_managed_update_command", return_value=None), \
|
|
patch("hermes_cli.config.detect_install_method", return_value="git"):
|
|
assert recommended_update_command() == "hermes update"
|
|
|
|
|
|
@pytest.mark.parametrize("false_value", ["false", "0", "no", "off", "FALSE"])
|
|
def test_get_managed_system_false_values(monkeypatch, false_value):
|
|
"""An explicit opt-out is not a package manager named "false" (#12864)."""
|
|
monkeypatch.setenv("HERMES_MANAGED", false_value)
|
|
|
|
assert get_managed_system() is None
|
|
assert not is_managed()
|
|
with patch("hermes_cli.config.detect_install_method", return_value="git"):
|
|
assert recommended_update_command() == "hermes update"
|
|
|
|
|
|
def test_optional_skill_source_honors_env_override(monkeypatch, tmp_path):
|
|
optional_dir = tmp_path / "optional-skills"
|
|
optional_dir.mkdir()
|
|
monkeypatch.setenv("HERMES_OPTIONAL_SKILLS", str(optional_dir))
|
|
|
|
source = OptionalSkillSource()
|
|
|
|
assert source._optional_dir == optional_dir
|