bdca94e749
The Codex gpt-5.5 compaction autoraise (#40957) overrode the effective threshold unconditionally. If a user had set compression.threshold above 0.85, agent_init dropped them down to 0.85. That wastes usable window and contradicts the feature's whole point: use more of the context, not less. It happened silently too, since the one-time notice is suppressed when the override doesn't raise. The override is an autoraise. It must only raise. Pulled the apply logic into a small pure helper that clamps the Codex case to never lower a higher-or-equal user threshold, and emits the notice only when it actually fires. Other overrides (Arcee Trinity) keep their existing unconditional behavior. Fixes the Codex gpt-5.5 compaction autoraise lowering a user's higher configured threshold. A user on the Codex OAuth route with compression.threshold > 0.85 was silently clamped to 0.85, compacting earlier than they asked and using less of the 272K window the feature was meant to unlock. The autoraise now only ever raises. N/A - [x] 🐛 Bug fix (non-breaking change that fixes an issue) - [ ] ✨ New feature (non-breaking change that adds functionality) - [ ] 🔒 Security fix - [ ] 📝 Documentation update - [ ] ✅ Tests (adding or improving test coverage) - [ ] ♻️ Refactor (no behavior change) - [ ] 🎯 New skill (bundled or hub) - `agent/agent_init.py`: added `_resolve_compression_threshold()`, a pure helper that combines the global threshold with a per-model override. The Codex gpt-5.5 autoraise never lowers a higher-or-equal user threshold; the notice is returned only when it actually raises. Rewired `init_agent` to call it, replacing the unconditional `compression_threshold = _model_cthresh`. - `tests/agent/test_arcee_trinity_overrides.py`: added 5 cases for the helper — raise from default, never-lower regression, equal-is-noop, no-override passthrough, and non-codex (Trinity) unconditional apply. 1. Set `compression.threshold: 0.90` and run gpt-5.5 on provider `openai-codex`. 2. Before: effective threshold drops to 0.85, no notice. After: stays 0.90. 3. Run `scripts/run_tests.sh tests/agent/test_arcee_trinity_overrides.py`. Stash `agent/agent_init.py` and the new cases fail; restore and they pass. - [x] I've read the [Contributing Guide](https://github.com/NousResearch/hermes-agent/blob/main/CONTRIBUTING.md) - [x] My commit messages follow [Conventional Commits](https://www.conventionalcommits.org/) (`fix(scope):`, `feat(scope):`, etc.) - [x] I searched for [existing PRs](https://github.com/NousResearch/hermes-agent/pulls) to make sure this isn't a duplicate - [x] My PR contains **only** changes related to this fix/feature (no unrelated commits) - [x] I've run `pytest tests/ -q` and all tests pass - [x] I've added tests for my changes (required for bug fixes, strongly encouraged for features) - [x] I've tested on my platform: macOS 15 (Darwin 25.5) - [x] I've updated relevant documentation (README, `docs/`, docstrings) — or N/A - [x] I've updated `cli-config.yaml.example` if I added/changed config keys — or N/A - [x] I've updated `CONTRIBUTING.md` or `AGENTS.md` if I changed architecture or workflows — or N/A - [x] I've considered cross-platform impact (Windows, macOS) per the [compatibility guide](https://github.com/NousResearch/hermes-agent/blob/main/CONTRIBUTING.md#cross-platform-compatibility) — or N/A - [x] I've updated tool descriptions/schemas if I changed tool behavior — or N/A