Teknium
c49fa88b80
* refactor(skills): shipped-set slim — 15 skills to optional, github six-way merge, pdf absorbs OCR+nano-pdf, channel-gated teams pipeline
Maintainer-directed shipped-skills curation (skills index 1,900 -> ~1,400
tok/call on desktop; every session pays the index, so this is a per-call
diet on all installs):
- optional-skills moves (installable via skills hub, history preserved):
creative comfyui/ascii-art/excalidraw/pretext/sketch/touchdesigner-mcp;
ALL of mlops (huggingface-hub, llama-cpp, serving-llms-vllm,
weights-and-biases, evaluating-llms-harness — subcategory structure
kept); research-paper-writing (55 supporting files, 17.3K-tok load);
openhue; blogwatcher (first taught the cronjob monitor-field watch
pattern + web_extract instead of pre-cron manual workflows)
- DELETED session-librarian (Aug-12 'inspired by Perplexity Computer'
port, never maintainer-intended; session_search covers discovery)
- github: six skills (auth, issues, pr-workflow, issue-to-pr,
code-review, repo-management) merged into ONE software-development/
github skill — routing body + complete per-workflow references;
benbarclay authorship credited; codebase-inspection rides along;
discipline pins from test_github_issue_to_pr_skill.py preserved
against the reference body in the new test_github_skill.py
- pdf absorbs ocr-and-documents + nano-pdf as references/ + scripts
(extract_pymupdf, extract_marker converted to the argparse house
standard its contract test enforces)
- NEW session_platforms frontmatter gate (metadata.hermes): hides a
skill from the index on gateway channels it is not for; fail-open on
unknown platform; teams-meeting-pipeline gated to [teams, cron]
- blocked-page-recovery: research -> new web category; trigger-first
description ('Use when a fetch fails: 403/429, paywall, WAF, bot
wall.') so the model actually reaches for it on blocked fetches
- docs regenerated via generate-skill-docs.py (195 pages); related_skills
swept repo-wide; tests: 1672 passed (2 openclaw failures pre-existing
on clean main, Windows-local)
* chore: ignore .skills_prompt_snapshot.json (local index cache, accidentally committed)
75 lines
2.4 KiB
Markdown
75 lines
2.4 KiB
Markdown
# Review Output Template
|
|
|
|
Use this as the structure for PR review summary comments. Copy and fill in the sections.
|
|
|
|
## For PR Summary Comment
|
|
|
|
```markdown
|
|
## Code Review Summary
|
|
|
|
**Verdict: [Approved ✅ | Changes Requested 🔴 | Reviewed 💬]** ([N] issues, [N] suggestions)
|
|
|
|
**PR:** #[number] — [title]
|
|
**Author:** @[username]
|
|
**Files changed:** [N] (+[additions] -[deletions])
|
|
|
|
### 🔴 Critical
|
|
<!-- Issues that MUST be fixed before merge -->
|
|
- **file.py:line** — [description]. Suggestion: [fix].
|
|
|
|
### ⚠️ Warnings
|
|
<!-- Issues that SHOULD be fixed, but not strictly blocking -->
|
|
- **file.py:line** — [description].
|
|
|
|
### 💡 Suggestions
|
|
<!-- Non-blocking improvements, style preferences, future considerations -->
|
|
- **file.py:line** — [description].
|
|
|
|
### ✅ Looks Good
|
|
<!-- Call out things done well — positive reinforcement -->
|
|
- [aspect that was done well]
|
|
|
|
---
|
|
*Reviewed by Hermes Agent*
|
|
```
|
|
|
|
## Severity Guide
|
|
|
|
| Level | Icon | When to use | Blocks merge? |
|
|
|-------|------|-------------|---------------|
|
|
| Critical | 🔴 | Security vulnerabilities, data loss risk, crashes, broken core functionality | Yes |
|
|
| Warning | ⚠️ | Bugs in non-critical paths, missing error handling, missing tests for new code | Usually yes |
|
|
| Suggestion | 💡 | Style improvements, refactoring ideas, performance hints, documentation gaps | No |
|
|
| Looks Good | ✅ | Clean patterns, good test coverage, clear naming, smart design decisions | N/A |
|
|
|
|
## Verdict Decision
|
|
|
|
- **Approved ✅** — Zero critical/warning items. Only suggestions or all clear.
|
|
- **Changes Requested 🔴** — Any critical or warning item exists.
|
|
- **Reviewed 💬** — Observations only (draft PRs, uncertain findings, informational).
|
|
|
|
## For Inline Comments
|
|
|
|
Prefix inline comments with the severity icon so they're scannable:
|
|
|
|
```
|
|
🔴 **Critical:** User input passed directly to SQL query — use parameterized queries to prevent injection.
|
|
```
|
|
|
|
```
|
|
⚠️ **Warning:** This error is silently swallowed. At minimum, log it.
|
|
```
|
|
|
|
```
|
|
💡 **Suggestion:** This could be simplified with a dict comprehension:
|
|
`{k: v for k, v in items if v is not None}`
|
|
```
|
|
|
|
```
|
|
✅ **Nice:** Good use of context manager here — ensures cleanup on exceptions.
|
|
```
|
|
|
|
## For Local (Pre-Push) Review
|
|
|
|
When reviewing locally before push, use the same structure but present it as a message to the user instead of a PR comment. Skip the PR metadata header and just start with the severity sections.
|