Teknium
72874b0675
* feat(skill_manage): operations[] batch — several ops on one skill, atomic with rollback (memory-tool pattern); staged as ONE pending write under the approval gate * refactor(skill_manage): operations[] IS the interface — single op = list of one (maintainer-directed); flat fields unadvertised handler compat; delete = sole-op routing * guard(skill_manage): reject intra-batch same-file clobbers — double write/remove per path, full rewrite after an earlier SKILL.md edit; patch chains stay legal * refactor(skill_manage): name-per-op — the call IS the operations array; cross-skill batches with all-touched-skills rollback * guard(skill_manage): unify the intra-batch conflict guard — any destructive op on an already-touched file is rejected, with path normalization Aggressive live testing found three holes in the two-part guard: patch-then-write and patch-then-remove on the same supporting file silently discarded the patch, and './references/x.md' //-style path spellings slipped past the duplicate-write check. One rule now covers the class: a destructive op (write_file/remove_file/full rewrite) on a (skill, normalized-path) any earlier op touched is rejected pre-effect; additive patches stay legal, so patch chains and write-then-patch still work. Tests cover all three holes plus the pre-effect assertion.
73 lines
3.2 KiB
Python
73 lines
3.2 KiB
Python
"""skill_manage schema diet contract (#95681, second pass).
|
|
|
|
Pins the deduped surface: patch args defer to the `patch` tool's matching
|
|
semantics instead of re-teaching them; file_path states its skill-dir-
|
|
relative shape; no authoring curriculum or confirm-with-user coaching in
|
|
the description (maintainer-directed cuts).
|
|
"""
|
|
import os
|
|
import sys
|
|
import unittest
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", ".."))
|
|
|
|
from tools.skill_manager_tool import SKILL_MANAGE_SCHEMA
|
|
|
|
|
|
class TestSkillManageSchemaDiet(unittest.TestCase):
|
|
def _op_props(self):
|
|
return SKILL_MANAGE_SCHEMA["parameters"]["properties"]["operations"]["items"]["properties"]
|
|
|
|
def test_single_call_shape(self):
|
|
"""Maintainer-directed: operations[] IS the interface — each op
|
|
names its skill; a single edit is a list of one. Flat fields are
|
|
handler-only compat."""
|
|
props = SKILL_MANAGE_SCHEMA["parameters"]["properties"]
|
|
self.assertEqual(sorted(props), ["operations"])
|
|
self.assertEqual(SKILL_MANAGE_SCHEMA["parameters"]["required"], ["operations"])
|
|
items = SKILL_MANAGE_SCHEMA["parameters"]["properties"]["operations"]["items"]
|
|
self.assertEqual(items["required"], ["name", "action"])
|
|
self.assertIn("delete", self._op_props()["action"]["enum"])
|
|
|
|
def test_patch_args_defer_to_patch_tool(self):
|
|
props = self._op_props()
|
|
self.assertIn("patch tool", props["old_string"]["description"])
|
|
# The uniqueness/context curriculum lives in the patch tool's schema,
|
|
# not here.
|
|
self.assertNotIn("unique", props["old_string"]["description"])
|
|
self.assertNotIn("surrounding context", props["old_string"]["description"])
|
|
|
|
def test_file_path_states_relative_shape(self):
|
|
desc = self._op_props()["file_path"]["description"]
|
|
self.assertIn("RELATIVE", desc)
|
|
self.assertIn("references/api.md", desc)
|
|
self.assertIn("never absolute", desc)
|
|
# The subdirectory whitelist is a real contract — must stay.
|
|
for sub in ("references/", "templates/", "scripts/", "assets/"):
|
|
self.assertIn(sub, desc)
|
|
|
|
def test_description_cuts_hold(self):
|
|
desc = SKILL_MANAGE_SCHEMA["description"]
|
|
# Maintainer-directed: no confirm-with-user coaching.
|
|
self.assertNotIn("Confirm with the user", desc)
|
|
# Authoring curriculum compressed to the 57-char trigger rule +
|
|
# skill_view pointer; the numbered-steps/pitfalls list is gone.
|
|
self.assertIn("57 chars", desc)
|
|
self.assertIn("skill_view()", desc)
|
|
self.assertNotIn("numbered steps", desc)
|
|
# Stale action vocabulary must not return.
|
|
self.assertNotIn("edit", self._op_props()["name"]["description"])
|
|
|
|
def test_content_keeps_pre_irreversibility_warning(self):
|
|
"""The REPLACES-whole-file warning is pre-irreversibility guidance:
|
|
an error can't teach after a successful full rewrite, so it must
|
|
stay schema-side (maintainer call). Lives in the description now
|
|
(op fields stay terse)."""
|
|
desc = SKILL_MANAGE_SCHEMA["description"]
|
|
self.assertIn("REPLACES", desc)
|
|
self.assertIn("skill_view()", desc)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|